Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Not for Merge] Remove legacy context #13420

Closed
wants to merge 5 commits into from
Closed

[Not for Merge] Remove legacy context #13420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
84f3303
Remove tests for legacy context
gaearon Aug 16, 2018
586c616
Remove context from shallow renderer
gaearon Aug 16, 2018
704acc5
Remove context from server renderer
gaearon Aug 16, 2018
4361e64
Remove context from Fiber
gaearon Aug 16, 2018
65cce78
Fix lint
gaearon Aug 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
53 changes: 0 additions & 53 deletions packages/react-dom/src/__tests__/ReactComponentLifeCycle-test.js
View file
Open in desktop
Expand Up @@ -12,7 +12,6 @@
let React;
let ReactDOM;
let ReactTestUtils;
let PropTypes;

const clone = function(o) {
return JSON.parse(JSON.stringify(o));
Expand Down Expand Up @@ -91,7 +90,6 @@ describe('ReactComponentLifeCycle', () => {
React = require('react');
ReactDOM = require('react-dom');
ReactTestUtils = require('react-dom/test-utils');
PropTypes = require('prop-types');
});

it('should not reuse an instance when it has been unmounted', () => {
Expand Down Expand Up @@ -920,57 +918,6 @@ describe('ReactComponentLifeCycle', () => {
);
});

it('calls effects on module-pattern component', function() {
const log = [];

function Parent() {
return {
render() {
expect(typeof this.props).toBe('object');
log.push('render');
return <Child />;
},
UNSAFE_componentWillMount() {
log.push('will mount');
},
componentDidMount() {
log.push('did mount');
},
componentDidUpdate() {
log.push('did update');
},
getChildContext() {
return {x: 2};
},
};
}
Parent.childContextTypes = {
x: PropTypes.number,
};
function Child(props, context) {
expect(context.x).toBe(2);
return <div />;
}
Child.contextTypes = {
x: PropTypes.number,
};

const div = document.createElement('div');
ReactDOM.render(<Parent ref={c => c && log.push('ref')} />, div);
ReactDOM.render(<Parent ref={c => c && log.push('ref')} />, div);

expect(log).toEqual([
'will mount',
'render',
'did mount',
'ref',

'render',
'did update',
'ref',
]);
});

it('should warn if getDerivedStateFromProps returns undefined', () => {
class MyComponent extends React.Component {
state = {};
Expand Down