Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ReactDOMFiber* to ReactDOM* #13540

Merged
merged 1 commit into from
Sep 3, 2018
Merged

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Sep 3, 2018

We used that naming when we had two implementations.
The main one was called just ReactDOMInput etc.

Now Fiber is the main one. If we want to fork some files for Fire, it will be confusing to differentiate between Fiber and Fire. So let's just unprefix for the current implementation.

@gaearon gaearon merged commit 9604d26 into facebook:master Sep 3, 2018
@pull-bot
Copy link

pull-bot commented Sep 3, 2018

Details of bundled changes.

Comparing: 28b9289...8061ba5

react-scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-scheduler.development.js +24.4% +23.6% 15.4 KB 19.17 KB 4.65 KB 5.74 KB UMD_DEV
react-scheduler.production.min.js 🔺+15.8% 🔺+21.0% 2.73 KB 3.16 KB 1.26 KB 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@nhunzaker
Copy link
Contributor

Woah. Nice!

jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants