New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add envify transform to scheduler package #13766

Merged
merged 1 commit into from Oct 4, 2018

Conversation

Projects
None yet
4 participants
@mridgway
Contributor

mridgway commented Oct 4, 2018

This package uses process.env.NODE_ENV but does not transform its usage during bundling like the rest of the React libraries do. This causes issues when process is not defined globally.

Add envify transform to scheduler package
This package uses `process.env.NODE_ENV` but does not transform its usage during bundling like the rest of the React libraries do. This causes issues when `process` is not defined globally.
@sizebot

This comment has been minimized.

sizebot commented Oct 4, 2018

Details of bundled changes.

Comparing: 4eabeef...b65f1de

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
scheduler.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@acdlite acdlite merged commit 605ab10 into facebook:master Oct 4, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@acdlite

This comment has been minimized.

Member

acdlite commented Oct 4, 2018

Thanks!

acdlite added a commit to plievone/react that referenced this pull request Oct 5, 2018

Add envify transform to scheduler package (facebook#13766)
This package uses `process.env.NODE_ENV` but does not transform its usage during bundling like the rest of the React libraries do. This causes issues when `process` is not defined globally.

linjiajian999 pushed a commit to linjiajian999/react that referenced this pull request Oct 22, 2018

Add envify transform to scheduler package (facebook#13766)
This package uses `process.env.NODE_ENV` but does not transform its usage during bundling like the rest of the React libraries do. This causes issues when `process` is not defined globally.

@gaearon gaearon referenced this pull request Oct 23, 2018

Merged

Add 16.6.0 changelog #13927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment