Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Suspense + rename Placeholder #13799

Merged
merged 3 commits into from Oct 10, 2018
Merged

Enable Suspense + rename Placeholder #13799

merged 3 commits into from Oct 10, 2018

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Oct 10, 2018 •
edited

  1. Removes client Suspense feature flag, it's now always on.
  2. Renames now-exposed <unstable_Placeholder delayMs> to <unstable_Suspense maxDuration>.
  3. Updates the fixture.

No whitespace: https://github.com/facebook/react/pull/13799/files?w=1.

DevTools: facebook/react-devtools#1182.

@gaearon gaearon mentioned this pull request Oct 10, 2018
Merged
sebmarkbage
sebmarkbage approved these changes Oct 10, 2018
View reviewed changes
Copy link
Collaborator

@sebmarkbage sebmarkbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t forget to codemod www for the sync.

@sizebot
Copy link

sizebot commented Oct 10, 2018

React: size: 🔺+1.3%, gzip: 🔺+1.1%

ReactDOM: size: 🔺+2.4%, gzip: 🔺+2.5%

Details of bundled changes.

Comparing: f47a958...40907ea

react

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react.development.js -0.1% -0.4% 92.6 KB 92.48 KB 24.5 KB 24.41 KB UMD_DEV
react.production.min.js 🔺+1.3% 🔺+1.1% 11.69 KB 11.84 KB 4.61 KB 4.66 KB UMD_PROD
react.development.js -1.6% -2.7% 55.98 KB 55.06 KB 15.32 KB 14.91 KB NODE_DEV
react.production.min.js 🔺+2.5% 🔺+2.3% 6.1 KB 6.25 KB 2.59 KB 2.65 KB NODE_PROD
React-dev.js -1.3% -1.6% 52.12 KB 51.43 KB 14.29 KB 14.07 KB FB_WWW_DEV
React-prod.js 🔺+1.3% -0.7% 14.17 KB 14.35 KB 3.94 KB 3.92 KB FB_WWW_PROD
React-profiling.js +1.3% -0.7% 14.17 KB 14.35 KB 3.94 KB 3.92 KB FB_WWW_PROFILING
react.profiling.min.js +1.1% +1.1% 13.84 KB 14 KB 5.12 KB 5.17 KB UMD_PROFILING

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js -0.1% -0.1% 657.48 KB 656.92 KB 153.61 KB 153.49 KB UMD_DEV
react-dom.production.min.js 🔺+2.4% 🔺+2.5% 93.33 KB 95.61 KB 30.37 KB 31.13 KB UMD_PROD
react-dom.development.js -0.1% -0.1% 652.82 KB 652.27 KB 152.23 KB 152.11 KB NODE_DEV
react-dom.production.min.js 🔺+2.4% 🔺+2.5% 93.32 KB 95.61 KB 29.97 KB 30.72 KB NODE_PROD
react-dom-server.browser.development.js -0.1% -0.1% 106.09 KB 106.03 KB 28.2 KB 28.18 KB UMD_DEV
react-dom-server.browser.production.min.js -0.0% -0.0% 15.36 KB 15.36 KB 5.87 KB 5.87 KB UMD_PROD
react-dom-server.browser.development.js -0.1% -0.1% 102.22 KB 102.16 KB 27.21 KB 27.18 KB NODE_DEV
react-dom-server.browser.production.min.js -0.0% -0.0% 15.26 KB 15.26 KB 5.82 KB 5.82 KB NODE_PROD
react-dom-server.node.development.js -0.1% -0.1% 104.14 KB 104.08 KB 27.77 KB 27.74 KB NODE_DEV
react-dom-server.node.production.min.js -0.0% -0.0% 16.07 KB 16.06 KB 6.12 KB 6.12 KB NODE_PROD
ReactDOM-dev.js -0.1% -0.1% 669.77 KB 669.2 KB 152.83 KB 152.71 KB FB_WWW_DEV
ReactDOM-prod.js -0.2% -0.2% 287.58 KB 286.97 KB 52.87 KB 52.77 KB FB_WWW_PROD
ReactDOMServer-dev.js -0.1% -0.1% 101.71 KB 101.64 KB 26.48 KB 26.47 KB FB_WWW_DEV
ReactDOMServer-prod.js -0.0% -0.0% 33.65 KB 33.63 KB 8.08 KB 8.08 KB FB_WWW_PROD
react-dom.profiling.min.js +2.2% +2.3% 96.3 KB 98.39 KB 30.59 KB 31.28 KB NODE_PROFILING
ReactDOM-profiling.js -0.2% -0.2% 293.76 KB 293.17 KB 54.22 KB 54.11 KB FB_WWW_PROFILING
react-dom.profiling.min.js +2.2% +2.4% 96.22 KB 98.32 KB 31.03 KB 31.76 KB UMD_PROFILING

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js -0.1% -0.1% 447.28 KB 446.73 KB 100.01 KB 99.88 KB UMD_DEV
react-art.production.min.js 🔺+2.7% 🔺+2.9% 85.72 KB 88.02 KB 26.21 KB 26.98 KB UMD_PROD
react-art.development.js -0.1% -0.2% 379.06 KB 378.51 KB 82.83 KB 82.7 KB NODE_DEV
react-art.production.min.js 🔺+4.5% 🔺+4.9% 50.69 KB 52.99 KB 15.48 KB 16.23 KB NODE_PROD
ReactART-dev.js -0.1% -0.1% 382.76 KB 382.19 KB 81.22 KB 81.11 KB FB_WWW_DEV
ReactART-prod.js -0.4% -0.3% 163.12 KB 162.53 KB 27.44 KB 27.35 KB FB_WWW_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js -0.1% -0.1% 391.27 KB 390.76 KB 85.42 KB 85.33 KB UMD_DEV
react-test-renderer.production.min.js 🔺+4.4% 🔺+4.9% 51.92 KB 54.23 KB 15.78 KB 16.55 KB UMD_PROD
react-test-renderer.development.js -0.1% -0.1% 386.85 KB 386.33 KB 84.3 KB 84.21 KB NODE_DEV
react-test-renderer.production.min.js 🔺+4.4% 🔺+5.0% 51.64 KB 53.94 KB 15.59 KB 16.37 KB NODE_PROD
react-test-renderer-shallow.development.js -0.0% -0.0% 26.32 KB 26.31 KB 7.07 KB 7.07 KB UMD_DEV
react-test-renderer-shallow.production.min.js -0.0% -0.0% 7.17 KB 7.17 KB 2.35 KB 2.35 KB UMD_PROD
react-test-renderer-shallow.development.js -0.1% -0.1% 20.82 KB 20.81 KB 5.66 KB 5.66 KB NODE_DEV
react-test-renderer-shallow.production.min.js -0.1% -0.0% 7.9 KB 7.89 KB 2.61 KB 2.61 KB NODE_PROD
ReactTestRenderer-dev.js -0.1% -0.1% 390.96 KB 390.41 KB 83.07 KB 82.95 KB FB_WWW_DEV
ReactShallowRenderer-dev.js -0.1% -0.1% 17.88 KB 17.86 KB 4.67 KB 4.67 KB FB_WWW_DEV

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js -0.1% -0.1% 374.89 KB 374.34 KB 80.93 KB 80.81 KB NODE_DEV
react-reconciler.production.min.js 🔺+4.5% 🔺+5.1% 50.38 KB 52.67 KB 15.02 KB 15.79 KB NODE_PROD
react-reconciler-persistent.development.js -0.1% -0.1% 373.45 KB 372.94 KB 80.34 KB 80.25 KB NODE_DEV
react-reconciler-persistent.production.min.js 🔺+4.5% 🔺+5.1% 50.39 KB 52.68 KB 15.03 KB 15.79 KB NODE_PROD
react-reconciler-reflection.development.js -0.1% -0.1% 16.09 KB 16.08 KB 4.88 KB 4.88 KB NODE_DEV

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js -0.1% -0.1% 506.98 KB 506.41 KB 111.87 KB 111.75 KB RN_FB_DEV
ReactNativeRenderer-prod.js -0.3% -0.3% 218.19 KB 217.59 KB 37.84 KB 37.74 KB RN_FB_PROD
ReactNativeRenderer-dev.js -0.1% -0.1% 506.67 KB 506.12 KB 111.79 KB 111.67 KB RN_OSS_DEV
ReactNativeRenderer-prod.js 🔺+4.5% 🔺+4.1% 208.2 KB 217.6 KB 36.25 KB 37.74 KB RN_OSS_PROD
ReactFabric-dev.js -0.1% -0.1% 497.13 KB 496.57 KB 109.44 KB 109.32 KB RN_FB_DEV
ReactFabric-prod.js 🔺+4.7% 🔺+4.5% 200.63 KB 210.06 KB 34.78 KB 36.33 KB RN_FB_PROD
ReactFabric-dev.js -0.1% -0.1% 497.16 KB 496.61 KB 109.46 KB 109.33 KB RN_OSS_DEV
ReactFabric-prod.js 🔺+4.7% 🔺+4.5% 200.67 KB 210.1 KB 34.79 KB 36.35 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js +3.4% +3.6% 215.53 KB 222.94 KB 37.68 KB 39.04 KB RN_OSS_PROFILING
ReactFabric-profiling.js +3.6% +3.8% 207.39 KB 214.81 KB 36.21 KB 37.59 KB RN_OSS_PROFILING
ReactNativeRenderer-profiling.js -0.3% -0.3% 223.51 KB 222.92 KB 39.13 KB 39.04 KB RN_FB_PROFILING
ReactFabric-profiling.js +3.6% +3.8% 207.35 KB 214.77 KB 36.19 KB 37.57 KB RN_FB_PROFILING

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
scheduler.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD
scheduler-tracing.development.js -0.4% -1.0% 10.12 KB 10.08 KB 2.29 KB 2.27 KB NODE_DEV
SchedulerTracing-dev.js -0.5% -0.2% 9.91 KB 9.87 KB 2.07 KB 2.07 KB FB_WWW_DEV

Generated by 🚫 dangerJS

@gaearon gaearon merged commit 8af6728 into facebook:master Oct 10, 2018
@klamping klamping mentioned this pull request Oct 10, 2018
Open
@NE-SmallTown
Copy link
Contributor

NE-SmallTown commented Oct 11, 2018 •
edited

Great work! Could I ask that is there any info can tell us about why make this into 16.6 rather than 17.0?

@gaearon
Copy link
Collaborator Author

gaearon commented Oct 11, 2018

It's not a breaking change.

@NE-SmallTown NE-SmallTown mentioned this pull request Oct 17, 2018
Merged
linjiajian999 pushed a commit to linjiajian999/react that referenced this pull request Oct 22, 2018
@gaearon
Enable Suspense + rename Placeholder (facebook#13799)
43627a4 
* Enable Suspense

* <unstable_Placeholder delayMs> => <unstable_Suspense maxDuration>

* Update suspense fixture
@gaearon gaearon mentioned this pull request Oct 23, 2018
Merged
This was referenced Oct 24, 2018
Closed
Closed
Open
Closed
Open
Open
Open
Open
Open
Merged
Merged
Closed
Merged
This was referenced Nov 1, 2018
Closed
Closed
@dependencies dependencies bot mentioned this pull request Dec 1, 2018
Open
This was referenced Dec 1, 2018
Open
Open
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
@gaearon @jetoneza
Enable Suspense + rename Placeholder (facebook#13799)
543e36e 
* Enable Suspense

* <unstable_Placeholder delayMs> => <unstable_Suspense maxDuration>

* Update suspense fixture
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gaearon @sizebot @NE-SmallTown @sebmarkbage @facebook-github-bot