Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scheduler] Rename priority levels #13842

Merged
merged 1 commit into from Oct 12, 2018

Conversation

Projects
None yet
5 participants
@acdlite
Copy link
Member

commented Oct 12, 2018

  • "Interactive" -> "User-blocking"
  • "Whenever" -> "Idle"

These are the terms used by @spanicker in their main-thread scheduling proposal: https://github.com/spanicker/main-thread-scheduling#api-sketch

That proposal also uses "microtask" instead of "immediate" and "default" instead of "normal." Not sure about "microtask" because I don't think most people know what that is. And our implementation isn't a proper microtask, though you could use it to implement microtasks if you made sure to wrap every entry point. I don't really have a preference between "default" and "normal."

These aren't necessarily the final names. Still prefixed by unstable_.

[scheduler] Rename priority levels
- "Interactive" -> "user-blocking"
- "Whenever" -> "Idle"

These are the terms used by @spanicker in their main-thread scheduling
proposal: https://github.com/spanicker/main-thread-scheduling#api-sketch

That proposal also uses "microtask" instead of "immediate" and "default"
instead of "normal." Not sure about "microtask" because I don't think
most people know what that is. And our implementation isn't a proper
microtask, though you could use it to implement microtasks if you made
sure to wrap every entry point. I don't really have a preference between
"default" and "normal."

These aren't necessarily the final names. Still prefixed by `unstable_`.
@sizebot

This comment has been minimized.

Copy link

commented Oct 12, 2018

Details of bundled changes.

Comparing: 3b7ee26...6073e96

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
scheduler.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD
scheduler.development.js -0.2% 0.0% 22.32 KB 22.27 KB 6.01 KB 6.01 KB NODE_DEV
scheduler.production.min.js -0.1% 0.0% 4.81 KB 4.81 KB 1.88 KB 1.88 KB NODE_PROD
Scheduler-dev.js -0.2% 0.0% 22.58 KB 22.53 KB 6.04 KB 6.04 KB FB_WWW_DEV
Scheduler-prod.js -0.0% 0.0% 13.64 KB 13.64 KB 2.92 KB 2.92 KB FB_WWW_PROD

Generated by 🚫 dangerJS

@gaearon
Copy link
Member

left a comment

i like

@acdlite acdlite merged commit c9be16f into facebook:master Oct 12, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@acdlite acdlite deleted the acdlite:rename-scheduler-priority-levels branch Oct 12, 2018

@bvaughn

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2018

me too

linjiajian999 pushed a commit to linjiajian999/react that referenced this pull request Oct 22, 2018

Andrew Clark linjiajian999
[scheduler] Rename priority levels (facebook#13842)
- "Interactive" -> "user-blocking"
- "Whenever" -> "Idle"

These are the terms used by @spanicker in their main-thread scheduling
proposal: https://github.com/spanicker/main-thread-scheduling#api-sketch

That proposal also uses "microtask" instead of "immediate" and "default"
instead of "normal." Not sure about "microtask" because I don't think
most people know what that is. And our implementation isn't a proper
microtask, though you could use it to implement microtasks if you made
sure to wrap every entry point. I don't really have a preference between
"default" and "normal."

These aren't necessarily the final names. Still prefixed by `unstable_`.

@gaearon gaearon referenced this pull request Oct 23, 2018

Merged

Add 16.6.0 changelog #13927

jetoneza added a commit to jetoneza/react that referenced this pull request Jan 23, 2019

[scheduler] Rename priority levels (facebook#13842)
- "Interactive" -> "user-blocking"
- "Whenever" -> "Idle"

These are the terms used by @spanicker in their main-thread scheduling
proposal: https://github.com/spanicker/main-thread-scheduling#api-sketch

That proposal also uses "microtask" instead of "immediate" and "default"
instead of "normal." Not sure about "microtask" because I don't think
most people know what that is. And our implementation isn't a proper
microtask, though you could use it to implement microtasks if you made
sure to wrap every entry point. I don't really have a preference between
"default" and "normal."

These aren't necessarily the final names. Still prefixed by `unstable_`.

iyegoroff added a commit to iyegoroff/react that referenced this pull request Mar 9, 2019

[scheduler] Rename priority levels (facebook#13842)
- "Interactive" -> "user-blocking"
- "Whenever" -> "Idle"

These are the terms used by @spanicker in their main-thread scheduling
proposal: https://github.com/spanicker/main-thread-scheduling#api-sketch

That proposal also uses "microtask" instead of "immediate" and "default"
instead of "normal." Not sure about "microtask" because I don't think
most people know what that is. And our implementation isn't a proper
microtask, though you could use it to implement microtasks if you made
sure to wrap every entry point. I don't really have a preference between
"default" and "normal."

These aren't necessarily the final names. Still prefixed by `unstable_`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.