Add "unstable_" prefix to react-cache and jest-react #13929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
Oct 23, 2018
scripts/error-codes/codes.json
Outdated
| "291": "Log of yielded values is not empty. Call expect(ReactTestRenderer).toHaveYielded(...) first.", | ||
| "292": "The matcher `toHaveYielded` expects an instance of React Test Renderer.\n\nTry: expect(ReactTestRenderer).toHaveYielded(expectedYields)" | ||
| "291": "Log of yielded values is not empty. Call expect(ReactTestRenderer).unstable_toHaveYielded(...) first.", | ||
| "292": "The matcher `unstable_toHaveYielded` expects an instance of React Test Renderer.\n\nTry: expect(ReactTestRenderer).unstable_toHaveYielded(expectedYields)" |
There was a problem hiding this comment.
Please revert? We don't change this file manually.
gaearon
reviewed
Oct 23, 2018
| @@ -18,12 +18,12 @@ describe('ReactCache', () => { | |||
| }); | |||
|
|
|||
| it('throws a promise if the requested value is not in the cache', async () => { | |||
| const {createCache, createResource} = ReactCache; | |||
| const {createCache, unstable_createResource} = ReactCache; | |||
There was a problem hiding this comment.
createCache isn't unstable but createResource is? Why?
There was a problem hiding this comment.
Andrew has concerns that createResource is less stable.
There was a problem hiding this comment.
ok just wanted to make sure it's intentional
There was a problem hiding this comment.
createCache doesn't exist anymore after I merge this: #13865
Let's land this PR as-is then I'll land mine.
Details of bundled changes.Comparing: 508b5fb...3001e23 scheduler
Generated by 🚫 dangerJS |
acdlite
approved these changes
Oct 23, 2018
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
* Add "unstable_" prefix to react-cache createResource and jest-react matchers * Reverted accidental change to error-codes JSON * Remove unstable_ prefix from internal React tests for jest-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "unstable_" prefix to
react-cachecreateResourceandjest-reactmatchers.