Rename inputsAreEqual to areHookInputsEqual & move it to shared #14036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ReactDOM: size: 0.0%, gzip: 0.0% Details of bundled changes.Comparing: bf9fadf...cc18195 react-dom
scheduler
Generated by 🚫 dangerJS |
Andarist
force-pushed
the
unify-inputs-diff-checker
branch
from
c62663e
to
7f558bc
Compare
Andarist
force-pushed
the
unify-inputs-diff-checker
branch
from
7f558bc
to
cc18195
Compare
nhunzaker
reviewed
Nov 2, 2018
There was a problem hiding this comment.
Hey! Thanks for sending this in!
This looks good from my end, and I like that it drops duplication, particularly for warnings. However someone else more familiar with SSR should take a look at this.
If one code path was missing a warning, is there any concern about that behavior changing?
@sophiebits who do you think is the best person to review this?
|
Seems OK to me. Shared means that it will get copied into each renderer which I guess is fine since that's effectively what we were manually doing before. Hooks aren't stable so we're allowed to have breaking changes (and we generally feel OK adding warnings in minor releases anyway since they don't affect behavior). |
|
Thanks! |
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know its bikeshedding but the name of this function triggered my OCD a little bit because it sounds (to me) like a name for a boolean variable. Most commonly other functions with similar purpose are named in the codebase with verb as first work, i.e.
isValidElementType.While renaming it I've also noticed that this code was duplicated and already out of sync (one having a dev warning, one not having it) so I thought it would be also a good thing to move it to shared directory to keep a single source of truth.