Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add ESLint rule for useEffect/useCallback/useMemo Hook dependencies #14052

Closed
wants to merge 9 commits into from
Closed

[WIP] Add ESLint rule for useEffect/useCallback/useMemo Hook dependencies #14052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f2d74d3
Add ESLint rule for useEffect/useCallback/useMemo Hook dependencies
calebmer Oct 31, 2018
41fec63
Fix ReactiveDependencies rule
jamiebuilds Oct 31, 2018
f227df8
fix lint errors
jamiebuilds Oct 31, 2018
5d5b180
Support useLayoutEffect
gaearon Jan 10, 2019
816b8ae
Add some failing tests and comments
gaearon Jan 10, 2019
e7f44f1
Gather dependencies in child scopes too
gaearon Jan 11, 2019
c1ab460
If we don't find foo.bar.baz in deps, try foo.bar, then foo
gaearon Jan 11, 2019
902cb08
foo is enough for both foo.bar and foo.baz
gaearon Jan 11, 2019
8797fa6
Shorter rule name
gaearon Jan 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion fixtures/eslint/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
},
"plugins": ["react-hooks"],
"rules": {
"react-hooks/rules-of-hooks": 2
"react-hooks/rules-of-hooks": 2,
"react-hooks/reactive-deps": 2
}
}
Loading