Fix crash during server render in React 16.6.0 #14103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for existence of `setTimeout` and `clearTimeout` in the runtime before using them, to ensure runtimes without them (like .NET ClearScript) do not crash just by importing `react-dom`.
|
ReactDOM: size: 🔺+0.1%, gzip: 0.0% Details of bundled changes.Comparing: ce90ffd...461eb5a react-dom
scheduler
Generated by 🚫 dangerJS |
|
Thanks |
|
Thank you @gaearon. Any ETA on when 16.6.1 (and the next 16.7 alpha) will be released? |
|
Soon-ish |
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
Check for existence of `setTimeout` and `clearTimeout` in the runtime before using them, to ensure runtimes without them (like .NET ClearScript) do not crash just by importing `react-dom`.
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
Check for existence of `setTimeout` and `clearTimeout` in the runtime before using them, to ensure runtimes without them (like .NET ClearScript) do not crash just by importing `react-dom`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced in React 16.6.0, which was not present in 16.5.2.
Runtimes without
setTimeoutandclearTimeout(e.g. ClearScript for .NET) are now crashing just by importingreact-dom.This replicates the fix for
schedulerintroduced in #13088 forreact-dom, by checking for existence ofsetTimeoutandclearTimeoutin the runtime before using them.