Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused simulated flag parameter #14127

Merged
merged 1 commit into from
Nov 7, 2018

Conversation

nadavkaner
Copy link
Contributor

@nadavkaner nadavkaner commented Nov 6, 2018

The behavior of the two modes is actually the same.

@sizebot
Copy link

sizebot commented Nov 6, 2018

ReactDOM: size: -0.1%, gzip: -0.1%

Details of bundled changes.

Comparing: f777d19...259b452

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js -0.1% -0.0% 705.75 KB 705.28 KB 163.47 KB 163.4 KB UMD_DEV
react-dom.production.min.js -0.1% -0.1% 98.04 KB 97.95 KB 31.88 KB 31.85 KB UMD_PROD
react-dom.development.js -0.1% -0.0% 701.07 KB 700.59 KB 162.1 KB 162.02 KB NODE_DEV
react-dom.production.min.js -0.1% -0.1% 98.03 KB 97.95 KB 31.41 KB 31.39 KB NODE_PROD
react-dom-test-utils.development.js -0.0% -0.0% 44.87 KB 44.86 KB 12.29 KB 12.29 KB UMD_DEV
react-dom-test-utils.production.min.js -0.0% -0.3% 9.96 KB 9.96 KB 3.71 KB 3.7 KB UMD_PROD
react-dom-test-utils.development.js -0.0% -0.0% 44.59 KB 44.58 KB 12.23 KB 12.23 KB NODE_DEV
react-dom-test-utils.production.min.js -0.0% -0.1% 9.74 KB 9.74 KB 3.64 KB 3.64 KB NODE_PROD
ReactDOM-dev.js -0.1% -0.1% 721.04 KB 720.5 KB 163.2 KB 163.09 KB FB_WWW_DEV
ReactDOM-prod.js -0.1% -0.1% 311.3 KB 310.86 KB 57.25 KB 57.19 KB FB_WWW_PROD
ReactTestUtils-dev.js -0.0% -0.0% 41.33 KB 41.32 KB 11.16 KB 11.16 KB FB_WWW_DEV
react-dom.profiling.min.js -0.1% -0.1% 100.8 KB 100.72 KB 31.96 KB 31.92 KB NODE_PROFILING
ReactDOM-profiling.js -0.1% -0.1% 317.5 KB 317.06 KB 58.49 KB 58.43 KB FB_WWW_PROFILING
react-dom.profiling.min.js -0.1% -0.1% 100.71 KB 100.63 KB 32.51 KB 32.48 KB UMD_PROFILING

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js -0.1% -0.1% 556.24 KB 555.7 KB 121.61 KB 121.5 KB RN_FB_DEV
ReactNativeRenderer-prod.js -0.0% -0.0% 240.21 KB 240.18 KB 42.22 KB 42.21 KB RN_FB_PROD
ReactNativeRenderer-dev.js -0.1% -0.1% 555.94 KB 555.4 KB 121.52 KB 121.4 KB RN_OSS_DEV
ReactNativeRenderer-prod.js -0.0% -0.0% 225.65 KB 225.63 KB 39.14 KB 39.13 KB RN_OSS_PROD
ReactFabric-dev.js -0.1% -0.1% 546.56 KB 546.02 KB 119.13 KB 119.01 KB RN_FB_DEV
ReactFabric-prod.js -0.0% -0.0% 219.9 KB 219.87 KB 37.82 KB 37.82 KB RN_FB_PROD
ReactFabric-dev.js -0.1% -0.1% 546.59 KB 546.05 KB 119.14 KB 119.03 KB RN_OSS_DEV
ReactFabric-prod.js -0.0% -0.0% 219.93 KB 219.91 KB 37.84 KB 37.83 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js -0.0% -0.0% 230.84 KB 230.81 KB 40.33 KB 40.32 KB RN_OSS_PROFILING
ReactFabric-profiling.js -0.0% -0.0% 224.2 KB 224.18 KB 39.07 KB 39.06 KB RN_OSS_PROFILING
ReactNativeRenderer-profiling.js -0.0% -0.0% 245.65 KB 245.62 KB 43.41 KB 43.41 KB RN_FB_PROFILING
ReactFabric-profiling.js -0.0% -0.0% 224.16 KB 224.14 KB 39.05 KB 39.04 KB RN_FB_PROFILING

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
scheduler.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@sophiebits sophiebits merged commit b4608dd into facebook:master Nov 7, 2018
@sophiebits
Copy link
Collaborator

Thanks!

jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
n8schloss pushed a commit to n8schloss/react that referenced this pull request Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants