Adding isMemo check to react-is package #14313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Nov 26, 2018
|
cc @gaearon @sebmarkbage any chance we could get a merge + minor release of react-is for this? |
Closed
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is related to #14278
What does it do?
Adds isMemo check to the react-is package.
Why?
Adding isMemo check will help to write a clean code for packages which are doing custom rendering, like Enzyme.
Please see the issue and PR raised on Enzyme
enzymejs/enzyme#1875
enzymejs/enzyme#1914