Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useDebugValue should throw if used in a class component #14601

Merged
merged 1 commit into from Jan 15, 2019
Merged

useDebugValue should throw if used in a class component #14601

merged 1 commit into from Jan 15, 2019

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Jan 15, 2019

No description provided.

@bvaughn bvaughn requested a review from acdlite January 15, 2019 21:19
@bvaughn bvaughn merged commit 4392e38 into facebook:master Jan 15, 2019
@bvaughn bvaughn deleted the useDebugValue-call-resolveCurrentlyRenderingFiber branch January 15, 2019 21:49
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
@bvaughn @jetoneza
useDebugValue should throw if used in a class component (facebook#14601)
373b53c
n8schloss pushed a commit to n8schloss/react that referenced this pull request Jan 31, 2019
@bvaughn @n8schloss
useDebugValue should throw if used in a class component (facebook#14601)
40ec6f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@threepointone threepointone threepointone approved these changes

@acdlite acdlite acdlite approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bvaughn @threepointone @acdlite @facebook-github-bot