Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an error when using hooks inside useMemo, or .memo's comparison function #14608

Merged
merged 16 commits into from
Jan 18, 2019
Merged

Throw an error when using hooks inside useMemo, or .memo's comparison function #14608

merged 16 commits into from
Jan 18, 2019

Commits on Jan 14, 2019

  1. hooks inside useMemo/.memo - failing tests

    Sunil Pai committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    00c01a9 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2019

  1. throw an error when using hooks inside useMemo

    Sunil Pai committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    59eed66 View commit details
    Browse the repository at this point in the history

  2. throw when using hooks inside .memo's compare fn

    Sunil Pai committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    f360274 View commit details
    Browse the repository at this point in the history

  3. faster/better/stronger

    Sunil Pai committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    4415d59 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2019

  1. same logic for useReducer, tests for the server, etc

    Sunil Pai committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    ec175a3 View commit details
    Browse the repository at this point in the history

  2. Update ReactDOMServerIntegrationHooks-test.internal.js 

    ack lint
    Sunil Pai committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    dacce6a View commit details
    Browse the repository at this point in the history

  3. nits

    Sunil Pai committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    78b3c6a View commit details
    Browse the repository at this point in the history

  4. whitespace

    Sunil Pai committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    fdd03f3 View commit details
    Browse the repository at this point in the history

  5. whitespace

    Sunil Pai committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    05aa71e View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into hooks-inside-memo-compare

    Sunil Pai committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    e37c6b8 View commit details
    Browse the repository at this point in the history

  7. stray semi

    Sunil Pai committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    aec0473 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2019

  1. Tweak comment

    @gaearon
    gaearon committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    a954f6c View commit details
    Browse the repository at this point in the history

  2. stray unmatched fiber reset

    Sunil Pai committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    49aa700 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'hooks-inside-memo-compare' of github.com:threepointone/… 

    …react into hooks-inside-memo-compare
    Sunil Pai committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    5d15312 View commit details
    Browse the repository at this point in the history

  4. nit

    Sunil Pai committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    ced4978 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/master' into hooks-inside-memo… 

    …-compare
    Sunil Pai committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    3242f68 View commit details
    Browse the repository at this point in the history