Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in comment #14739

Merged
merged 2 commits into from Feb 1, 2019
Merged

Typo in comment #14739

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78a67fd
Typo in comment
DenrizSusam Jan 31, 2019
ec9febf
Update createSubscription-test.internal.js
DenrizSusam Jan 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/create-subscription/src/__tests__/createSubscription-test.internal.js
View file
Open in desktop
Expand Up @@ -148,7 +148,7 @@ describe('createSubscription', () => {

// Test a promise that resolves before render
// Note that this will require an extra render anyway,
// Because there is no way to syncrhonously get a Promise's value
// Because there is no way to synchronously get a Promise's value
rejectB(false);
ReactNoop.render(<Subscription source={promiseB}>{render}</Subscription>);
expect(ReactNoop.flush()).toEqual(['loading']);
Expand Down Expand Up @@ -431,7 +431,7 @@ describe('createSubscription', () => {
'Parent.componentDidUpdate',
]);

// Updates from the new subsribable should be ignored.
// Updates from the new subscribable should be ignored.
observableB.next('b-1');
expect(ReactNoop.flush()).toEqual([]);
expect(log).toEqual([
Expand Down