-
Notifications
You must be signed in to change notification settings - Fork 47.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ignored sync work in passive effects #14799
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiebits
reviewed
Feb 9, 2019
I'll let @acdlite review this one. Whenever he sees a bug like this, he finds two others. |
gaearon
force-pushed
the
flush-sync-effect-work
branch
from
February 11, 2019 14:33
597e8ec
to
d51fff3
Compare
Fixed batching, good repro @sophiebits |
We do the same thing at the end of |
acdlite
approved these changes
Feb 11, 2019
This was referenced Aug 12, 2019
This was referenced Aug 20, 2019
This was referenced Aug 27, 2019
This was referenced Sep 20, 2019
Open
[Snyk] Upgrade react-dom from 16.5.2 to 16.9.0
maxiplux/spring-security-react-ant-design-polls-app#3
Open
This was referenced Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #14792. I don't really know this code but this is my guess.
Specifically, this code doesn't always end up being called from a root work cycle. It can run from the scheduler (indeed, that's the normal case). In that case
isRendering
is true inside (soReactDOM.render
doesn't do anything) but we don't flush anything before the exit. Now we do.This delays the actual render until the end of calling effects. I think it makes sense as it's consistent with what we do for commit phase effects.