-
Notifications
You must be signed in to change notification settings - Fork 48.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UMD builds by re-exporting the scheduler priorities #14914
Conversation
unstable_ImmediatePriority, | ||
unstable_LowPriority, | ||
unstable_NormalPriority, | ||
unstable_UserBlockingPriority, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the important part of the fix. The rest isn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving, but I suppose andrew should have a look too
I built a version of the fixtures with this change: Looks good to me, 👍 |
## 16.8.2 => 16.8.3 ### React DOM * Fix a bug that caused inputs to behave incorrectly in UMD builds. ([@gaearon](https://github.com/gaearon) in [#14914](facebook/react#14914)) * Fix a bug that caused render phase updates to be discarded. ([@gaearon](https://github.com/gaearon) in [#14852](facebook/react#14852)) ### React DOM Server * Unwind the context stack when a stream is destroyed without completing, to prevent incorrect values during a subsequent render. ([@overlookmotel](https://github.com/overlookmotel) in [#14706](facebook/react#14706))
## 16.8.2 => 16.8.3 ### React DOM * Fix a bug that caused inputs to behave incorrectly in UMD builds. ([@gaearon](https://github.com/gaearon) in [#14914](facebook/react#14914)) * Fix a bug that caused render phase updates to be discarded. ([@gaearon](https://github.com/gaearon) in [#14852](facebook/react#14852)) ### React DOM Server * Unwind the context stack when a stream is destroyed without completing, to prevent incorrect values during a subsequent render. ([@overlookmotel](https://github.com/overlookmotel) in [#14706](facebook/react#14706))
Closes #14904.
Fixes the regression to UMD builds since #14756 which caused all interactive updates in 16.8.2 to be scheduled with low priority.
We had a test that checked for those but it used to ignore priorities because it wasn't important at the time. I'm making the test check those too.
Since the existing test also verifies the Scheduler UMD bundles, I added getters to those to make sure the API matches up. But that's not the important part of this fix. The important part is just adding those constants to "scheduler internals" for UMD.
Note this means that even ReactDOM 16.8.3+ won't work correctly with older React UMDs. This might be surprising but it breaks often enough for UMDs that it's probably okay.