Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReactNoop.yield -> Scheduler.yieldValue #15008

Merged
merged 1 commit into from Mar 4, 2019
Merged

ReactNoop.yield -> Scheduler.yieldValue #15008

merged 1 commit into from Mar 4, 2019

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Mar 4, 2019

These used to be different things, but now ReactNoop.yield merely re-exports Scheduler.yieldValue, so let's get rid of it.

@acdlite
ReactNoop.yield -> Scheduler.yieldValue
0cfef27 
These used to be different things, but now ReactNoop.yield merely
re-exports Scheduler.yieldValue, so let's get rid of it.
threepointone
threepointone approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

masterful grepping, truly

@acdlite acdlite merged commit 757a70b into facebook:master Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@threepointone threepointone threepointone approved these changes

@sebmarkbage sebmarkbage sebmarkbage approved these changes

@bvaughn bvaughn Awaiting requested review from bvaughn

@gaearon gaearon Awaiting requested review from gaearon

@trueadm trueadm Awaiting requested review from trueadm

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@acdlite @threepointone @sebmarkbage @facebook-github-bot