Adds react-events package for internal testing #15150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundled changes.Comparing: d926936...2ac6750 react-events
Generated by 🚫 dangerJS |
gaearon
reviewed
Mar 19, 2019
acdlite
reviewed
Mar 19, 2019
|
|
||
| // TODO: decide on the top-level export form. | ||
| // This is hacky but makes it work with both Rollup and Jest. | ||
| module.exports = ReactEvents.default || ReactEvents; |
There was a problem hiding this comment.
I don't think we've been doing this on our new packages. See: https://github.com/facebook/react/blob/master/packages/react-cache/index.js
This was referenced Mar 19, 2019
This was referenced Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
react-eventspackage that will act as the home for the user-facing APIs for the experimental event API. This package is only intended for internal testing right now. This also adds a bundle to the build script so we can build thereact-eventspackage to consume internally.This PR will be a dependency for #15112.