Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store entire build directory as CI artifacts #15310

Merged
merged 3 commits into from Apr 4, 2019
Merged

Store entire build directory as CI artifacts #15310

merged 3 commits into from Apr 4, 2019

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Apr 3, 2019 •
edited

Updates the Circle CI config to store Facebook bundles as build artifacts. We already do this for our npm packages.

Update: Might as well store entire build/ directory

@acdlite
Store FB bundles as CI artifacts
35f94df 
Updates the Circle CI config to store Facebook bundles as build
artifacts. We already do this for our npm packages.
@acdlite acdlite requested a review from bvaughn April 3, 2019 18:16
@acdlite acdlite changed the title Store FB bundles as CI artifacts Store entire build directory as CI artifacts Apr 3, 2019
bvaughn
bvaughn reviewed Apr 3, 2019
View reviewed changes
Copy link
Contributor

@bvaughn bvaughn left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well store entire build/ directory

I think we should use a similar approach as pack_and_store_artifact.sh that just packs up the FB facebook-www into a TGZ so that we have a single thing to download and extract during our sync, rather than each of these individual ones

Screen Shot 2019-04-03 at 1 11 25 PM

@acdlite
Store build directory as a tarball
e427258 
So it's easy to download
@acdlite
Copy link
Collaborator Author

acdlite commented Apr 3, 2019

Good call

@acdlite
Copy link
Collaborator Author

acdlite commented Apr 3, 2019 •
edited

@bvaughn Ok it now stores the build/ directory as a tarball. The node_modules tarball used by the release script is unchanged.
Screen Shot 2019-04-03 at 4 37 40 PM

bvaughn
bvaughn approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig it.

@acdlite acdlite merged commit 1dcab97 into facebook:master Apr 4, 2019
@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvaughn bvaughn bvaughn approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@acdlite @bvaughn @facebook-github-bot