Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React.unstable_createEventComponent #15580

Merged
merged 1 commit into from May 7, 2019

Conversation

necolas
Copy link
Contributor

@necolas necolas commented May 7, 2019

Introduces a new unstable API for creating event components from event responders.

Ref #15257

API for creating event components from event responders.
Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff :)

@sizebot
Copy link

sizebot commented May 7, 2019

React: size: 🔺+0.3%, gzip: 🔺+0.3%

Details of bundled changes.

Comparing: 2e5d1a8...d52b802

react

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react.development.js +0.4% +0.7% 107.47 KB 107.92 KB 27.21 KB 27.39 KB UMD_DEV
react.production.min.js 🔺+0.3% 🔺+0.3% 12.28 KB 12.33 KB 4.78 KB 4.8 KB UMD_PROD
react.profiling.min.js +0.3% +0.3% 14.44 KB 14.48 KB 5.3 KB 5.32 KB UMD_PROFILING
react.development.js +0.6% +0.5% 69.65 KB 70.09 KB 17.95 KB 18.04 KB NODE_DEV
react.production.min.js 🔺+0.7% 🔺+0.5% 6.44 KB 6.48 KB 2.67 KB 2.69 KB NODE_PROD
React-dev.js +0.6% +0.5% 67.92 KB 68.36 KB 17.29 KB 17.38 KB FB_WWW_DEV
React-prod.js 🔺+1.9% 🔺+1.7% 16.02 KB 16.32 KB 4.24 KB 4.31 KB FB_WWW_PROD
React-profiling.js +1.9% +1.7% 16.02 KB 16.32 KB 4.24 KB 4.31 KB FB_WWW_PROFILING

react-events

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-events.development.js 0.0% +0.2% 1.16 KB 1.16 KB 617 B 618 B UMD_DEV
react-events.production.min.js 0.0% 🔺+0.5% 682 B 682 B 430 B 432 B UMD_PROD
react-events.development.js 0.0% +0.2% 996 B 996 B 555 B 556 B NODE_DEV
react-events.production.min.js 0.0% 🔺+0.6% 512 B 512 B 353 B 355 B NODE_PROD
react-events-press.development.js -10.7% -16.5% 21.25 KB 18.97 KB 5.17 KB 4.32 KB UMD_DEV
react-events-press.production.min.js -10.8% -13.2% 8.09 KB 7.21 KB 2.9 KB 2.51 KB UMD_PROD
react-events-press.development.js -1.6% -2.9% 21.08 KB 20.73 KB 5.13 KB 4.98 KB NODE_DEV
react-events-press.production.min.js -0.9% -1.3% 7.92 KB 7.85 KB 2.84 KB 2.81 KB NODE_PROD
ReactEventsPress-dev.js -1.7% -3.5% 19.42 KB 19.08 KB 4.43 KB 4.28 KB FB_WWW_DEV
ReactEventsPress-prod.js -0.9% -2.0% 16.04 KB 15.89 KB 3.34 KB 3.27 KB FB_WWW_PROD
react-events-hover.development.js -3.5% -6.3% 9.47 KB 9.14 KB 2.36 KB 2.21 KB UMD_DEV
react-events-hover.production.min.js -1.6% -2.0% 3.88 KB 3.82 KB 1.45 KB 1.42 KB UMD_PROD
react-events-hover.development.js -3.7% -6.7% 9.3 KB 8.95 KB 2.32 KB 2.16 KB NODE_DEV
react-events-hover.production.min.js -2.0% -3.0% 3.72 KB 3.65 KB 1.4 KB 1.36 KB NODE_PROD
ReactEventsHover-dev.js -3.6% -6.8% 9.29 KB 8.96 KB 2.32 KB 2.16 KB FB_WWW_DEV
ReactEventsHover-prod.js -1.9% -4.0% 7.68 KB 7.54 KB 1.82 KB 1.75 KB FB_WWW_PROD
react-events-focus.development.js -5.1% -8.4% 6.63 KB 6.3 KB 1.81 KB 1.66 KB UMD_DEV
react-events-focus.production.min.js -1.9% -2.7% 2.84 KB 2.78 KB 1.13 KB 1.09 KB UMD_PROD
react-events-focus.development.js -5.4% -9.0% 6.46 KB 6.11 KB 1.75 KB 1.6 KB NODE_DEV
react-events-focus.production.min.js -2.8% -4.2% 2.67 KB 2.59 KB 1.06 KB 1.02 KB NODE_PROD
ReactEventsFocus-dev.js -5.3% -9.1% 6.43 KB 6.09 KB 1.75 KB 1.59 KB FB_WWW_DEV
ReactEventsFocus-prod.js -2.2% -4.0% 5.34 KB 5.22 KB 1.34 KB 1.28 KB FB_WWW_PROD
react-events-focus-scope.development.js -6.6% -9.9% 5.06 KB 4.72 KB 1.57 KB 1.41 KB UMD_DEV
react-events-focus-scope.production.min.js -2.8% -2.4% 2.02 KB 1.96 KB 1003 B 979 B UMD_PROD
react-events-focus-scope.development.js -7.1% -11.0% 4.88 KB 4.54 KB 1.52 KB 1.35 KB NODE_DEV
react-events-focus-scope.production.min.js -4.1% -4.5% 1.84 KB 1.77 KB 934 B 892 B NODE_PROD
ReactEventsFocusScope-dev.js -6.8% -10.9% 4.88 KB 4.54 KB 1.51 KB 1.35 KB FB_WWW_DEV
ReactEventsFocusScope-prod.js -3.1% -4.5% 3.85 KB 3.73 KB 1.15 KB 1.1 KB FB_WWW_PROD
react-events-swipe.development.js -27.1% -32.8% 8.39 KB 6.12 KB 2.56 KB 1.72 KB UMD_DEV
react-events-swipe.production.min.js -24.9% -23.5% 3.51 KB 2.64 KB 1.6 KB 1.23 KB UMD_PROD
react-events-swipe.development.js -4.2% -6.3% 8.22 KB 7.87 KB 2.53 KB 2.37 KB NODE_DEV
react-events-swipe.production.min.js -2.2% -2.7% 3.35 KB 3.27 KB 1.55 KB 1.51 KB NODE_PROD
ReactEventsSwipe-dev.js -5.4% -8.9% 6.32 KB 5.98 KB 1.79 KB 1.63 KB FB_WWW_DEV
ReactEventsSwipe-prod.js -2.6% -4.7% 5.93 KB 5.78 KB 1.53 KB 1.46 KB FB_WWW_PROD
react-events-drag.development.js -28.7% -34.7% 7.93 KB 5.66 KB 2.45 KB 1.6 KB UMD_DEV
react-events-drag.production.min.js -26.0% -25.7% 3.37 KB 2.5 KB 1.53 KB 1.13 KB UMD_PROD
react-events-drag.development.js -4.5% -6.6% 7.77 KB 7.42 KB 2.42 KB 2.26 KB NODE_DEV
react-events-drag.production.min.js -2.3% -2.0% 3.21 KB 3.14 KB 1.46 KB 1.43 KB NODE_PROD
ReactEventsDrag-dev.js -5.6% -9.1% 6.02 KB 5.68 KB 1.71 KB 1.55 KB FB_WWW_DEV
ReactEventsDrag-prod.js -2.8% -4.8% 5.5 KB 5.34 KB 1.43 KB 1.36 KB FB_WWW_PROD

Generated by 🚫 dangerJS

@necolas necolas merged commit 89d8d14 into facebook:master May 7, 2019
@necolas necolas deleted the react/create-event-component branch December 20, 2019 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants