refactor(getComponentName): Use element types instead of fiber types #15638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ReactDOM: size: 0.0%, gzip: 0.0% Details of bundled changes.Comparing: 07da821...899a0b3 react-dom
react-art
react-test-renderer
react-native-renderer
react-reconciler
Generated by 🚫 dangerJS |
eps1lon
commented
May 13, 2019
| // Host root, text node or just invalid type. | ||
| return null; | ||
| } | ||
| if (__DEV__) { | ||
| if (typeof (type: any).tag === 'number') { | ||
| // TODO: protect against potential false positives from user-defined statics | ||
| if (typeof (elementType: any).tag === 'number') { |
There was a problem hiding this comment.
The check was introduced in #13197. Seems like this was meant as a helper for the transition period since it was used on the full fiber previously.
It's probably better to remove this altogether. An unknown component name should appear in the tests leading to a fail instead of a different error message.
Using _debugID is likely best to reduce the number of false positives.
Using isValidElementType leads to breakage in the internal React.lazy tests.
eps1lon
force-pushed
the
refactor/getComponentName/use-elementType
branch
from
8c1450f
to
3134205
Compare
eps1lon
force-pushed
the
refactor/getComponentName/use-elementType
branch
from
3134205
to
899a0b3
Compare
eps1lon
force-pushed
the
refactor/getComponentName/use-elementType
branch
from
899a0b3
to
5a6abe7
Compare
|
ReactDOM: size: 0.0%, gzip: 0.0% Details of bundled changes.Comparing: 980112b...73d54f5 react-art
react-dom
react-test-renderer
react-reconciler
react-native-renderer
|
eps1lon
force-pushed
the
refactor/getComponentName/use-elementType
branch
from
5a6abe7
to
73d54f5
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution. |
|
I'll resolve merge conflicts. |
eps1lon
force-pushed
the
refactor/getComponentName/use-elementType
branch
from
73d54f5
to
08485d9
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b1f4a5c:
|
Details of bundled changes.Comparing: 9ea0f67...b1f4a5c react-dom
react-native-renderer
react-art
react-test-renderer
react-reconciler
ReactDOM: size: 0.0%, gzip: -0.1% Size changes (experimental) |
Details of bundled changes.Comparing: 9ea0f67...b1f4a5c react-dom
react-art
react-test-renderer
react-native-renderer
react-reconciler
ReactDOM: size: 0.0%, gzip: -0.1% Size changes (stable) |
eps1lon
force-pushed
the
refactor/getComponentName/use-elementType
branch
2 times, most recently
from
31cb7e8
to
7e65fde
Compare
eps1lon
force-pushed
the
refactor/getComponentName/use-elementType
branch
from
7e65fde
to
bda6a9b
Compare
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
eps1lon
force-pushed
the
refactor/getComponentName/use-elementType
branch
from
bda6a9b
to
b1f4a5c
Compare
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
|
Closing due to missing interest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since fiber types can change during work (see MemoComponent -> SimpleMemoComponent) it seems more appropriate to use the elementType instead to determine a component name.
Makes #15313 easier (see #15313 (comment)). It would also enable #14319 since we no longer rely on internal data structures (fiber types) but public element types.