[Fresh] Set up infra for runtime and Babel plugin #15698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundled changes.Comparing: 9c9ea94...4dbd247 react-fresh
Generated by 🚫 dangerJS |
acdlite
approved these changes
May 21, 2019
| const ReactFreshBabelPlugin = require('./src/ReactFreshBabelPlugin'); | ||
|
|
||
| // This is hacky but makes it work with both Rollup and Jest. | ||
| module.exports = ReactFreshBabelPlugin.default || ReactFreshBabelPlugin; |
There was a problem hiding this comment.
I thought new packages can use ES modules.
There was a problem hiding this comment.
I don't think we enabled ESM output for anything yet because of how DEV/PROD split is done.
gaearon
added a commit
to gaearon/react
that referenced
this pull request
Jun 11, 2019
* Add a stub for React Fresh Babel plugin package * Move ReactFresh-test into ReactFresh top level directory * Add a stub for React Fresh Runtime entry point * Extract Fresh runtime from tests into its entry point
gaearon
added a commit
to gaearon/react
that referenced
this pull request
Jun 19, 2019
* Add a stub for React Fresh Babel plugin package * Move ReactFresh-test into ReactFresh top level directory * Add a stub for React Fresh Runtime entry point * Extract Fresh runtime from tests into its entry point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-freshtop level package.react-fresh/babelentry point.react-fresh/runtimeentry point.I want to keep it all in this repo so that I can write integration tests which run against latest React, and verify all pieces work together. This also makes it easier to ensure we actually fix this if we break it.
The next follow-up will be to actually write the Babel plugin, and add some kind of integration testing.