chore: make tests compatible with Jest 24 #15779

SimenB · 2019-05-30T12:53:39Z

This is #15778 without the actual upgrade to Jest 24 (as that breaks CI). I'm hopeful this will pass so it can land, then the diff for Jest 24 is just config changes.

Note that this does upgrade jest to the latest 23 release, which is why the lockfile has so many changes

sizebot · 2019-05-30T12:57:58Z

No significant bundle size changes to report.

Generated by 🚫 dangerJS

SimenB · 2019-05-30T16:19:54Z

scripts/jest/setupEnvironment.js

@@ -9,10 +9,6 @@ global.__PROFILE__ = NODE_ENV === 'development';
 global.__UMD__ = false;

 if (typeof window !== 'undefined') {
-  global.requestAnimationFrame = function(callback) {


jsdom comes with raf

SimenB · 2019-05-30T16:20:15Z

packages/react-dom/src/events/__tests__/ChangeEventPlugin-test.internal.js

    // - calling 'window.postMessage' should actually fire postmessage handlers
-    global.requestAnimationFrame = function(cb) {
-      return setTimeout(() => {
-        cb(Date.now());


the raf from jsdom passes in the timestamp. is this safe to remove?

SimenB · 2019-08-07T11:46:36Z

@threepointone I've rebased this PR. I'd love to see it land, then landing the upgrade to Jest 24 should be simpler as the diff will be cleaner

SimenB · 2019-08-07T12:01:05Z

scripts/jest/config.base.js

@@ -21,4 +21,5 @@ module.exports = {
  collectCoverageFrom: ['packages/**/*.js'],
  timers: 'fake',
  snapshotSerializers: [require.resolve('jest-snapshot-serializer-raw')],
+  testURL: 'about:blank',


Note that doing this breaks in JSDOM@>=11.12 with SecurityError: localStorage is not available for opaque origins which is why the default has changed in Jest. Can try to do something for this when Jest 25 is released, which will force a newer version of JSDOM.

For now, I've manually made sure the entry in the lockfile is ~11.11.0, which does not have this issue

Could you add a short TODO here?

ergh, expect it wasn't particularly short 😅

threepointone

This LGTM! I’ll merge it later today after I try it locally just to be doubly sure.

threepointone · 2019-08-07T12:03:15Z

scripts/jest/config.base.js

@@ -21,4 +21,5 @@ module.exports = {
  collectCoverageFrom: ['packages/**/*.js'],
  timers: 'fake',
  snapshotSerializers: [require.resolve('jest-snapshot-serializer-raw')],
+  testURL: 'about:blank',


Could you add a short TODO here?

packages/eslint-plugin-react-hooks/__tests__/ESLintRuleExhaustiveDeps-test.js

package.json

SimenB · 2019-08-07T13:19:42Z

scripts/jest/preprocessor.js

@@ -70,7 +70,7 @@ module.exports = {
              }
            : {}
        )
-      ).code;


removing this ensures you return source maps to Jest, for better errors and debugging.

SimenB · 2019-08-09T10:38:21Z

@threepointone congrats on the 16.9 release 😀 I've rebased this after #16297 was merged

SimenB · 2019-08-09T10:42:23Z

packages/react-dom/src/__tests__/ReactDOMServerIntegrationElements-test.js

@@ -651,7 +651,7 @@ describe('ReactDOMServerIntegration', () => {
      });
    });

-    describe('component hierarchies', async function() {


describe must be void (in reality it must be synchronous) in Jest. async here was always an error, but it throws with jest 24.

https://jestjs.io/docs/en/troubleshooting#defining-tests

SimenB · 2019-08-09T10:43:18Z

packages/react/src/__tests__/ReactCoffeeScriptClass-test.coffee

@@ -543,3 +543,4 @@ describe 'ReactCoffeeScriptClass', ->
    node = ReactDOM.findDOMNode(instance)
    expect(node).toBe container.firstChild
    undefined
+  undefined


same as the async describe - the return value must be void.

SimenB · 2019-08-09T11:01:12Z

Since I was messing with the jest setup, I also sent #16332 which seems to have uncovered some erroneously passing tests

threepointone · 2019-08-14T10:53:41Z

I merged the other one before this one, and this now has a conflict with yarn.lock. Sorry! 😅If you could rebase and make sure the lockfile is fine, I'll merge this in. Thank you!

Co-Authored-By: Sunil Pai <threepointone@oculus.com>

SimenB · 2019-08-14T11:02:54Z

Rebased! 🙂

SimenB · 2019-08-14T11:49:04Z

🎉

SimenB force-pushed the jest-24-without-version-bump branch from cda46a0 to 96fdb14 Compare May 30, 2019 12:53

facebook-github-bot added the CLA Signed label May 30, 2019

SimenB mentioned this pull request May 30, 2019

chore: upgrade to jest 24 #15778

Merged

SimenB force-pushed the jest-24-without-version-bump branch from 96fdb14 to 601f157 Compare May 30, 2019 13:01

SimenB commented May 30, 2019

View reviewed changes

SimenB force-pushed the jest-24-without-version-bump branch from 02f4bec to 7d6f4a3 Compare June 11, 2019 10:57

SimenB force-pushed the jest-24-without-version-bump branch from 7d6f4a3 to ae0dfe7 Compare August 7, 2019 11:31

SimenB commented Aug 7, 2019

View reviewed changes

threepointone approved these changes Aug 7, 2019

View reviewed changes

threepointone reviewed Aug 7, 2019

View reviewed changes

SimenB commented Aug 7, 2019

View reviewed changes

package.json Outdated Show resolved Hide resolved

SimenB commented Aug 7, 2019

View reviewed changes

SimenB force-pushed the jest-24-without-version-bump branch 2 times, most recently from 81db1dd to 081bd2e Compare August 9, 2019 10:37

SimenB commented Aug 9, 2019

View reviewed changes

SimenB force-pushed the jest-24-without-version-bump branch from 25865db to 74c40df Compare August 13, 2019 23:59

threepointone approved these changes Aug 14, 2019

View reviewed changes

SimenB and others added 4 commits August 14, 2019 13:00

chore: make tests compatible with Jest 24

1a5effe

remove fake rafs

8f92867

rollback jsdom for localstorage compat

78130ee

Apply suggestions from code review

b7ce9a9

Co-Authored-By: Sunil Pai <threepointone@oculus.com>

SimenB force-pushed the jest-24-without-version-bump branch from 74c40df to b7ce9a9 Compare August 14, 2019 11:01

chore: cleanup lockfile

1f24938

threepointone merged commit e308a03 into facebook:master Aug 14, 2019

SimenB deleted the jest-24-without-version-bump branch August 14, 2019 11:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: make tests compatible with Jest 24 #15779

chore: make tests compatible with Jest 24 #15779

SimenB commented May 30, 2019

sizebot commented May 30, 2019

SimenB May 30, 2019

SimenB May 30, 2019

SimenB commented Aug 7, 2019

SimenB Aug 7, 2019 •

edited

Loading

threepointone Aug 7, 2019

SimenB Aug 7, 2019

SimenB Aug 7, 2019

threepointone left a comment

threepointone Aug 7, 2019

SimenB Aug 7, 2019 •

edited

Loading

SimenB commented Aug 9, 2019

SimenB Aug 9, 2019

SimenB Aug 9, 2019

SimenB commented Aug 9, 2019

threepointone commented Aug 14, 2019

SimenB commented Aug 14, 2019

SimenB commented Aug 14, 2019

@@ @@ -70,7 +70,7 @@ module.exports = { @@
                             }
                           : {}
                       )
-                    ).code;

chore: make tests compatible with Jest 24 #15779

chore: make tests compatible with Jest 24 #15779

Conversation

SimenB commented May 30, 2019

sizebot commented May 30, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SimenB commented Aug 7, 2019

SimenB Aug 7, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

threepointone left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SimenB Aug 7, 2019 • edited Loading

Choose a reason for hiding this comment

SimenB commented Aug 9, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SimenB commented Aug 9, 2019

threepointone commented Aug 14, 2019

SimenB commented Aug 14, 2019

SimenB commented Aug 14, 2019

SimenB Aug 7, 2019 •

edited

Loading

SimenB Aug 7, 2019 •

edited

Loading