Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't fire missing act() warnings for react-art #15975

Merged
merged 3 commits into from Jun 24, 2019
Merged

don't fire missing act() warnings for react-art #15975

merged 3 commits into from Jun 24, 2019

Commits on Jun 24, 2019

  1. use toWarnDev for dom fixture tests 

    forks toWarnDev from root into fixture/dom, updates tes tests to use it
    @threepointone
    threepointone committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    abe2406 View commit details
    Browse the repository at this point in the history

  2. disable act() warnings for react-art() 

    - For 'secondary' renderers like react-act, we don't want to fire missing act() warnings; the wrapping renderer will fire warnings anyway, and when it flushes, it flushes effects *across* renderers.

- I could have used isPrimaryRenderer as the flag, but this is marked as false for react-test-renderer, and we *do* want the warning to fire for it. Hence a new flag.
    @threepointone
    threepointone committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    88fe0b4 View commit details
    Browse the repository at this point in the history

  3. add missing dependency art to fixtures/dom

    @threepointone
    threepointone committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    e5bf5fe View commit details
    Browse the repository at this point in the history