Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade art fixtures to babel 7 #16235

Merged
merged 4 commits into from
Jul 26, 2020
Merged

Upgrade art fixtures to babel 7 #16235

merged 4 commits into from
Jul 26, 2020

Conversation

epicfaace
Copy link
Contributor

Part of #12548.

@sizebot
Copy link

sizebot commented Jul 28, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS

@epicfaace
Copy link
Contributor Author

I'm not sure whom to ask to review this, maybe @gaearon ?

@ahtee
Copy link

ahtee commented Aug 9, 2019

I'm not sure whom to ask to review this, maybe @gaearon ?

@acdlite :)

@threepointone
Copy link
Contributor

This seems fine to me, could you rebase and verify it's still all ok?

@ahtee
Copy link

ahtee commented Sep 4, 2019 •
edited
Loading

Is plugin-proposal-class-properties included with the @babel/preset-env or already? I'd have to check, but I'm assuming yes..
I would have though it would be apart of either @babel/preset-env or @babel/preset-react.

@sizebot
Copy link

sizebot commented Sep 5, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS against 05f0c36

@stale
Copy link

stale bot commented Jan 10, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Jan 10, 2020
@epicfaace
Copy link
Contributor Author

@acdlite ?

@stale stale bot removed the Resolution: Stale Automatically closed due to inactivity label Jan 12, 2020
@stale
Copy link

stale bot commented Apr 11, 2020

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Apr 11, 2020
@epicfaace
Copy link
Contributor Author

bump

@stale stale bot removed the Resolution: Stale Automatically closed due to inactivity label Apr 11, 2020
@stale
Copy link

stale bot commented Jul 11, 2020

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Jul 11, 2020
@epicfaace
Copy link
Contributor Author

Bump

@stale stale bot removed the Resolution: Stale Automatically closed due to inactivity label Jul 11, 2020
@ahtee
Copy link

ahtee commented Jul 15, 2020

@epicfaace please stop bumping the issue. The team will get to the issue when possible.

@epicfaace
Copy link
Contributor Author

epicfaace commented Jul 15, 2020 •
edited
Loading

@ahtee just making sure it doesn't get automatically closed by stale bot ... ¯_(ツ)_/¯ wouldn't have bumped it if not for that reason

@rickhanlonii
Copy link
Member

@epicfaace no worry, the stalebot message above specifically asks you to bump it if it's still relevant 👍

@rickhanlonii
Copy link
Member

@epicfaace thanks again for submitting this, since this is so old could you rebase and update to the latest versions?

I'll make sure to get this in, ping me when it's done!

@epicfaace
Copy link
Contributor Author

@rickhanlonii should be ready now -- thanks!

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 20, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e037f47:

Sandbox Source
React Configuration

rickhanlonii
rickhanlonii requested changes Jul 22, 2020
View reviewed changes
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close, but could you remove the package-lock.json added and use yarn to install instead?

@epicfaace
Copy link
Contributor Author

@rickhanlonii should be ready now.

rickhanlonii
rickhanlonii approved these changes Jul 26, 2020
View reviewed changes
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickhanlonii rickhanlonii merged commit 5530f1c into facebook:master Jul 26, 2020
@rickhanlonii
Copy link
Member

Thanks!

@epicfaace epicfaace deleted the babel7 branch July 26, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickhanlonii rickhanlonii rickhanlonii approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@epicfaace @sizebot @ahtee @threepointone @rickhanlonii @facebook-github-bot