Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing check to unmocked Scheduler warning #16261

Merged
merged 1 commit into from
Jul 31, 2019

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Jul 31, 2019

The unmocked Scheduler warning doesn't actually check if Scheduler is mocked.

Only affects www because the warnAboutUnmockedScheduler feature flag is off in the open source build.

The unmocked Scheduler warning doesn't actually check if Scheduler
is mocked.
@sizebot
Copy link

sizebot commented Jul 31, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS

@acdlite
Copy link
Collaborator Author

acdlite commented Jul 31, 2019

Merging to unblock sync

@acdlite acdlite merged commit 3756167 into facebook:master Jul 31, 2019
@threepointone
Copy link
Contributor

Sorry! 😣 Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants