[Scheduler] Delete old rAF implementation #16271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our performance tests indicate that the message loop implementation has better CPU utilization than the current rAF one. This commit removes the feature flag and deletes the rAF implementation.
|
React: size: -2.2%, gzip: -3.3% Details of bundled changes.Comparing: f440bfd...5113349 react
scheduler
Generated by 🚫 dangerJS |
gaearon
reviewed
Aug 15, 2019
| runtime.assertLog(['Message Event', 'A', 'B']); | ||
| }); | ||
|
|
||
| it('multiple tasks with a yield in between', () => { |
There was a problem hiding this comment.
This test breaks after the min heap refactor.
There was a problem hiding this comment.
Ok that's because it needs 4999 instead of 5000 now. Must be some comparison condition flip. Probably doesn't matter.
gaearon
added a commit
to gaearon/react
that referenced
this pull request
Aug 15, 2019
|
Since we want to keep both for now, I pulled all test except |
This was referenced Aug 15, 2019
gaearon
added a commit
that referenced
this pull request
Aug 19, 2019
* Add a regression test for cancelCallback with message loop * If there's nothing scheduled, we're not running * Add more tests from #16271
|
Will open new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our performance tests indicate that the message loop implementation has better CPU utilization than the current rAF one. This commit removes the feature flag and deletes the rAF implementation.
I removed the old SchedulerDOM tests because they assumed a rAF implementation. I ported the relevant tests to the SchedulerBrowser test suite.
Opening the PR now, but I won't merge this until after 16.9.