Upgrade ESLint so we can use JSX Fragment syntax #16328
Conversation
| @@ -65,6 +60,9 @@ module.exports = { | |||
| 'no-var': ERROR, | |||
| strict: ERROR, | |||
|
|
|||
| // Enforced by Prettier | |||
| 'max-len': OFF, | |||
There was a problem hiding this comment.
I was getting some weird syntax error in a transitive module. Google didn't turn up anything so I decided to turn it off since the length is enforced by Prettier, anyway.
There was a problem hiding this comment.
Prettier won’t warn for long strings tho, and won’t rewrite them either. Which... may be fine?
There was a problem hiding this comment.
fwiw, this also yelled at me for long line comments, which prettier doesn't touch
There was a problem hiding this comment.
I'll add a comment so the next person who looks at it knows why I turned it off.
|
^ Oops didn't mean to delete that. Sizebot says the base commit is broken because the coverage went down slightly after the Babel 7 PR. |
|
No significant bundle size changes to report. Generated by 🚫 dangerJS |
Now that we're using Babel 7, this is the last blocker.
acdlite
force-pushed
the
upgrade-eslint
branch
3 times, most recently
from
6a170a4
to
3402eac
Compare
Now that we're using Babel 7, this is the last blocker.
Now that we're using Babel 7, this is the last blocker.