Work around a Scheduler bug #16391
Closed
Work around a Scheduler bug #16391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No significant bundle size changes to report. Generated by 🚫 dangerJS |
sebmarkbage
reviewed
Aug 14, 2019
| @@ -406,7 +406,8 @@ if ( | |||
| }; | |||
|
|
|||
| cancelHostCallback = function() { | |||
| scheduledHostCallback = null; | |||
| // TODO: Uncomment when we know why this breaks www. | |||
| // scheduledHostCallback = null; | |||
There was a problem hiding this comment.
I'm not comfortable with this. This line wasn't added in the PR and there are other semantic changes in that PR but it was supposed to be an observational only change. The change also doesn't seem to be fully encapsulated behind the feature flag.
E.g. I don't understand this behavior change: a34ca7b#diff-603a307ec39e05daabd1c651dc2ffb15R407
I should've reviewed more carefully.
|
This actually looks insufficient. The first problem went away but I found another one (a freeze). Let's revert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #16145 which introduced them.