Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable MessageLoop implementation by default #16408

Merged
merged 1 commit into from
Sep 5, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/scheduler/src/SchedulerFeatureFlags.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ export const enableSchedulerDebugging = false;
export const enableIsInputPending = false;
export const requestIdleCallbackBeforeFirstFrame = false;
export const requestTimerEventBeforeFirstFrame = false;
export const enableMessageLoopImplementation = false;
export const enableMessageLoopImplementation = true;
export const enableProfiling = __PROFILE__;
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ type FrameTimeoutConfigType = {
timePastFrameDeadline: ?number,
};

describe('SchedulerDOM', () => {
// Note: this is testing the implementation that we turned off.
// enableMessageLoopImplementation is true on master.
describe('SchedulerRAFOld', () => {
let rAFCallbacks = [];
let postMessageCallback;
let postMessageEvents = [];
Expand Down Expand Up @@ -101,6 +103,7 @@ describe('SchedulerDOM', () => {
),
);

require('scheduler/src/SchedulerFeatureFlags').enableMessageLoopImplementation = false;
Scheduler = require('scheduler');
});

Expand Down
6 changes: 3 additions & 3 deletions packages/scheduler/src/forks/SchedulerFeatureFlags.www.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
export const {
enableIsInputPending,
enableSchedulerDebugging,
requestIdleCallbackBeforeFirstFrame,
requestTimerEventBeforeFirstFrame,
enableMessageLoopImplementation,
} = require('SchedulerFeatureFlags');

export const enableProfiling = __PROFILE__;
export const requestIdleCallbackBeforeFirstFrame = false;
export const requestTimerEventBeforeFirstFrame = false;
export const enableMessageLoopImplementation = true;