Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ReactThreadIdAllocator): rephrase comment #16559

Merged
merged 1 commit into from
Aug 29, 2019
Merged

chore(ReactThreadIdAllocator): rephrase comment #16559

merged 1 commit into from
Aug 29, 2019

Conversation

jamesgeorge007
Copy link
Contributor

@jamesgeorge007 jamesgeorge007 commented Aug 23, 2019 •
edited
Loading

tightly packed array sounds much better 馃槃

sidenote: Google search would suggest the respective phrase instead

@sizebot
Copy link

sizebot commented Aug 23, 2019

No significant bundle size changes to report.

Generated by 馃毇 dangerJS

trueadm
trueadm approved these changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for this.

@trueadm trueadm merged commit 980112b into facebook:master Aug 29, 2019
@jamesgeorge007 jamesgeorge007 deleted the hotfix/rephrase-comment branch August 29, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueadm trueadm trueadm approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jamesgeorge007 @sizebot @trueadm @facebook-github-bot