Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add integrity field in yarn.lock #16601

Merged
merged 1 commit into from
Aug 29, 2019
Merged

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Aug 28, 2019

While rebasing #15778, I noticed a ton of dependencies were missing an integrity field in the lockfile, creating more conflicts than necessary (and although yarn auto-solves merge conflicts, it should reduce the diff anyways).

@sizebot
Copy link

sizebot commented Aug 28, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS

@threepointone
Copy link
Contributor

Thanks for this! Will merge if you can fix the conflict, cheers!

@SimenB
Copy link
Contributor Author

SimenB commented Aug 29, 2019

rebased 🙂

@sizebot
Copy link

sizebot commented Aug 29, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS against 653b9bf

@trueadm
Copy link
Contributor

trueadm commented Aug 29, 2019

@threepointone Are you happy with merging this PR now?

@threepointone
Copy link
Contributor

lol I thought I had, sorry! merging!

@threepointone threepointone merged commit ac61936 into facebook:master Aug 29, 2019
@SimenB SimenB deleted the yarn-integrity branch August 29, 2019 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants