-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use-subscription tearing fix #16623
use-subscription tearing fix #16623
Conversation
jest.runAllTimers(); | ||
|
||
// Partial update "C" -> "D" | ||
// Interrupt with a second mutation "D" -> "E" but this should not cause tearing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This second interrupting mutation is required to trigger the previous failure. (Described in more detail in this issue comment.) I don't yet understand why this is but will be digging in more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like React eagerly computes the state initially, for the first update. It doesn't do this or subsequent updates though because expirationTime !== NoWork
.
I'm not sure if this is expected, given that my test flushes all pending work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acdlite and I chatted about this offline and I have a better understanding of it now. I've updated the inline test comments. Going to hand this PR to him since he has full context now too.
Details of bundled changes.Comparing: f962feb...5ba5309 use-subscription
|
Ping @acdlite :) |
Adds a test (previously failing) and a fix for a potential tearing case reported in #16396.
Resolves #16396