[react-events] Keyboard responder propagation handling #16657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ReactDOM: size: 0.0%, gzip: -0.0% Details of bundled changes.Comparing: 539640d...4290034 react-dom
|
necolas
approved these changes
Sep 4, 2019
gaearon
reviewed
Sep 10, 2019
| const previouslyInEventHandler = isInsideEventHandler; | ||
| try { | ||
| isInsideEventHandler = true; | ||
| const type = typeof value === 'object' && value !== null ? value.type : ''; | ||
| invokeGuardedCallbackAndCatchFirstError(type, fn, undefined, value); |
There was a problem hiding this comment.
Is there a follow-up to fix this? It seems important that event handler doesn't crash the rest of the code?
There was a problem hiding this comment.
Yeah, I plan on addressing it this week.
There was a problem hiding this comment.
This was already fixed in a follow-up right? This guard is still there on master
There was a problem hiding this comment.
LOL. I did, I’m clearly losing the plot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for conditional Keyboard responder propagation, for where there are nested keyboard responders. To allow a
onKeyDownoronKeyUpevent to propagate the callback is required to returntrueto propagate a single responder level. This is done by providing a new method on context calledcontinuePropagation– which tells the responder propagation system to propagate a single level after processing the current responder (of the same responder type).I also had to remove the usage of
invokeGuardedCallbackAndCatchFirstErrorwhen calling the user-land event callback. This was because the existinginvokeGuardedCallbackAndCatchFirstErrordoesn't support returning a value from the callback – which is what we need here. Attempting to change the mechanics of the function seemed far too invasive, so we can test this approach out internally to see if we run into any issues (we shouldn't though).