Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-events] Fix isTargetWithinNode type #16671

Merged

Conversation

necolas
Copy link
Contributor

@necolas necolas commented Sep 5, 2019

isTargetWithinNode passes the childTarget to getClosestInstanceFromNode which
does not account for a null value of 'node'.

isTargetWithinNode passes the childTarget to getClosestInstanceFromNode which
does not account for a null value of 'node'.
@sizebot
Copy link

sizebot commented Sep 5, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS against a3efc11

@necolas necolas merged commit ff00645 into facebook:master Sep 5, 2019
@necolas necolas deleted the react-dom/fix-isTargetWithinNode-type branch December 20, 2019 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants