Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DevTools] Fixed font family issue in Firefox. #16701

Merged
merged 1 commit into from
Sep 9, 2019
Merged

[DevTools] Fixed font family issue in Firefox. #16701

merged 1 commit into from
Sep 9, 2019

Conversation

hristo-kanchev
Copy link
Contributor

Fixes: #16464

It appears that we need to explicitly set the font-family for FF.

Screenshot:
Screenshot 2019-09-07 at 19 30 13

@hristo-kanchev hristo-kanchev changed the title Fixed font family issue in FF. [DevTools] Fixed font family issue in FF. Sep 7, 2019
@hristo-kanchev hristo-kanchev changed the title [DevTools] Fixed font family issue in FF. [DevTools] Fixed font family issue in Firefox. Sep 7, 2019
@sizebot
Copy link

sizebot commented Sep 7, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS against 68dc5c5

bvaughn
bvaughn approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't object to this change. It's also doesn't seem necessary for my OS+Firefox though. :)

@bvaughn bvaughn merged commit 4905590 into facebook:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvaughn bvaughn bvaughn approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DevTools: Tooltips appear to be Times New Roman in Firefox
4 participants
@hristo-kanchev @sizebot @bvaughn @facebook-github-bot