[react-interactions] More Tab Focus control handling #16751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ReactDOM: size: 0.0%, gzip: 0.0% Details of bundled changes.Comparing: ae724be...029805a react-art
react-dom
react-test-renderer
react-reconciler
react-native-renderer
|
necolas
reviewed
Sep 11, 2019
Fix typo Address feedback
trueadm
force-pushed
the
tab-focus-controller
branch
from
9ea52f4
to
02e2471
Compare
necolas
approved these changes
Sep 11, 2019
packages/react-dom/src/client/focus/__tests__/TabFocusController-test.internal.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up PR to the previous initial work to handle basic tab focus control with
TabFocusController.jss.This PR adds a few more features to the experimental scope API and, most importantly, provides an internal imperative mechanism for controlling tab focus via an API. I've also made containment an optional prop on
TabFocusControllers and provided a way of exposing an imperative ref to scopes so these can easily be handed back via scope traversal.In my next PR I plan on demonstrating taking this future and building components that allow for a powerful Grid based keyboard focusable system (using arrows + tab + modifiers).