Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-interaction] Tweak Focus Table component #16862

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Sep 23, 2019

This PR cleans up some of the variables names in FocusTable that were not named right. It also adds preventDefault to keyboard presses that move focus and ensures we use elementType for the scope fibers to ensure reconciliation doesn't discard scopes on each update.

@sizebot
Copy link

sizebot commented Sep 23, 2019

Details of bundled changes.

Comparing: d7f6dd5...f4d76ee

react-interactions

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-interactions-events/focus.development.js 0.0% -0.0% 10.93 KB 10.93 KB 2.36 KB 2.36 KB UMD_DEV
react-interactions-events/press.development.js 0.0% -0.1% 5.03 KB 5.03 KB 1.43 KB 1.43 KB UMD_DEV
react-interactions-events/tap.development.js 0.0% -0.0% 17.5 KB 17.5 KB 3.75 KB 3.75 KB UMD_DEV
react-interactions-events/press.production.min.js 0.0% -0.1% 2.25 KB 2.25 KB 983 B 982 B UMD_PROD
react-interactions-events/tap.production.min.js 0.0% -0.0% 6.19 KB 6.19 KB 2.34 KB 2.34 KB UMD_PROD
ReactFocusTable-dev.js +1.6% +0.6% 6.68 KB 6.79 KB 1.59 KB 1.6 KB FB_WWW_DEV
react-interactions-events/context-menu.development.js 0.0% -0.1% 2.68 KB 2.68 KB 1006 B 1005 B UMD_DEV
react-interactions-events/input.development.js 0.0% -0.1% 4.52 KB 4.52 KB 1.44 KB 1.44 KB UMD_DEV
react-interactions-events/scroll.development.js 0.0% -0.1% 6.3 KB 6.3 KB 1.65 KB 1.65 KB UMD_DEV
react-interactions-events/context-menu.production.min.js 0.0% -0.1% 1.39 KB 1.39 KB 729 B 728 B UMD_PROD
react-interactions-events/context-menu.development.js 0.0% -0.1% 2.49 KB 2.49 KB 960 B 959 B NODE_DEV
react-interactions-events/input.development.js 0.0% -0.1% 4.34 KB 4.34 KB 1.4 KB 1.4 KB NODE_DEV
react-interactions-events/scroll.development.js 0.0% -0.1% 6.12 KB 6.12 KB 1.61 KB 1.61 KB NODE_DEV
react-interactions-accessibility/tab-focus.development.js 0.0% -0.1% 4.79 KB 4.79 KB 1.25 KB 1.25 KB NODE_DEV
react-interactions-events/context-menu.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 668 B 667 B NODE_PROD
react-interactions-events/input.production.min.js 0.0% -0.2% 1.66 KB 1.66 KB 917 B 915 B NODE_PROD
react-interactions-events/scroll.production.min.js 0.0% -0.1% 2.44 KB 2.44 KB 1.09 KB 1.09 KB NODE_PROD
react-interactions-accessibility/tab-focus.production.min.js 0.0% -0.2% 1.79 KB 1.79 KB 856 B 854 B NODE_PROD
react-interactions-events/hover.production.min.js 0.0% -0.1% 3.12 KB 3.12 KB 1.13 KB 1.13 KB UMD_PROD
react-interactions-events/press-legacy.production.min.js 0.0% -0.0% 6.98 KB 6.98 KB 2.63 KB 2.63 KB UMD_PROD
react-interactions-events/hover.development.js 0.0% -0.1% 6.82 KB 6.82 KB 1.51 KB 1.51 KB NODE_DEV
react-interactions-events/press-legacy.development.js 0.0% -0.0% 20.55 KB 20.55 KB 4.78 KB 4.78 KB NODE_DEV
react-interactions-accessibility/focus-table.development.js +1.7% +0.5% 6.86 KB 6.97 KB 1.64 KB 1.64 KB NODE_DEV
react-interactions-events/hover.production.min.js 0.0% -0.1% 2.94 KB 2.94 KB 1.07 KB 1.07 KB NODE_PROD
react-interactions-accessibility/focus-table.production.min.js 🔺+3.6% 🔺+2.6% 2.3 KB 2.39 KB 1001 B 1 KB NODE_PROD
ReactFocusTable-prod.js 🔺+5.5% 🔺+1.5% 5.89 KB 6.21 KB 1.38 KB 1.4 KB FB_WWW_PROD
react-interactions-events/press.development.js 0.0% -0.1% 4.74 KB 4.74 KB 1.36 KB 1.35 KB NODE_DEV
react-interactions-events/tap.development.js 0.0% -0.0% 17.32 KB 17.32 KB 3.69 KB 3.69 KB NODE_DEV
react-interactions-events/focus.production.min.js 0.0% -0.1% 3.93 KB 3.93 KB 1.32 KB 1.32 KB NODE_PROD
react-interactions-events/press.production.min.js 0.0% -0.4% 1.96 KB 1.96 KB 889 B 885 B NODE_PROD
react-interactions-events/tap.production.min.js 0.0% -0.0% 6.03 KB 6.03 KB 2.28 KB 2.28 KB NODE_PROD
react-interactions-events/drag.development.js 0.0% -0.1% 5.23 KB 5.23 KB 1.54 KB 1.54 KB UMD_DEV
react-interactions-events/keyboard.development.js 0.0% -0.0% 5.75 KB 5.75 KB 2.14 KB 2.14 KB UMD_DEV
react-interactions-events/swipe.development.js 0.0% -0.1% 6 KB 6 KB 1.63 KB 1.62 KB UMD_DEV
react-interactions-events/drag.production.min.js 0.0% -0.1% 2.25 KB 2.25 KB 1.07 KB 1.07 KB UMD_PROD
react-interactions-events/keyboard.production.min.js 0.0% -0.1% 2.41 KB 2.41 KB 1.21 KB 1.21 KB UMD_PROD
react-interactions-events/swipe.production.min.js 0.0% -0.1% 2.45 KB 2.45 KB 1.11 KB 1.1 KB UMD_PROD
react-interactions-events/drag.development.js 0.0% -0.0% 6.98 KB 6.98 KB 2.21 KB 2.21 KB NODE_DEV
react-interactions-events/keyboard.development.js 0.0% -0.0% 5.57 KB 5.57 KB 2.1 KB 2.1 KB NODE_DEV
react-interactions-events/swipe.development.js 0.0% -0.1% 5.82 KB 5.82 KB 1.58 KB 1.58 KB NODE_DEV
react-interactions-accessibility/tabbable-scope.development.js 0.0% -0.2% 1.18 KB 1.18 KB 583 B 582 B NODE_DEV
react-interactions-events/drag.production.min.js 0.0% -0.1% 2.88 KB 2.88 KB 1.38 KB 1.38 KB NODE_PROD
react-interactions-events/keyboard.production.min.js 0.0% -0.1% 2.23 KB 2.23 KB 1.16 KB 1.16 KB NODE_PROD
react-interactions-events/swipe.production.min.js 0.0% -0.2% 2.27 KB 2.27 KB 1.05 KB 1.05 KB NODE_PROD
react-interactions-accessibility/tabbable-scope.production.min.js 0.0% -0.2% 680 B 680 B 447 B 446 B NODE_PROD

Generated by 🚫 dangerJS against f4d76ee

@trueadm trueadm merged commit 70754f1 into facebook:master Sep 23, 2019
@trueadm trueadm deleted the scope-and-a11y-fixes branch September 23, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants