Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-interactions] Add no-op stopPropagation + preventDefault to Press #16868

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Sep 23, 2019

This re-introduces the warning back for Press responders for using preventDefault and stopPropagation. Otherwise the operation on these is a no-op for prod mode.

@sizebot
Copy link

sizebot commented Sep 23, 2019

Details of bundled changes.

Comparing: 013b7ad...2ef1bc7

react-interactions

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-interactions-events/focus.development.js 0.0% -0.0% 10.93 KB 10.93 KB 2.36 KB 2.36 KB UMD_DEV
react-interactions-events/press.development.js +76.8% +87.0% 5.03 KB 8.89 KB 1.43 KB 2.67 KB UMD_DEV
react-interactions-events/press.production.min.js 🔺+12.7% 🔺+14.0% 2.25 KB 2.53 KB 983 B 1.09 KB UMD_PROD
ReactEventsPressLegacy-dev.js +10.8% +16.7% 21.34 KB 23.65 KB 4.96 KB 5.79 KB FB_WWW_DEV
react-interactions-events/input.development.js 0.0% -0.1% 4.52 KB 4.52 KB 1.44 KB 1.44 KB UMD_DEV
react-interactions-events/scroll.development.js 0.0% -0.1% 6.3 KB 6.3 KB 1.65 KB 1.65 KB UMD_DEV
react-interactions-events/context-menu.production.min.js 0.0% -0.1% 1.39 KB 1.39 KB 729 B 728 B UMD_PROD
react-interactions-events/input.production.min.js 0.0% -0.1% 1.84 KB 1.84 KB 984 B 983 B UMD_PROD
react-interactions-events/scroll.production.min.js 0.0% -0.1% 2.63 KB 2.63 KB 1.15 KB 1.15 KB UMD_PROD
react-interactions-events/context-menu.development.js 0.0% -0.1% 2.49 KB 2.49 KB 961 B 960 B NODE_DEV
react-interactions-events/input.development.js 0.0% -0.1% 4.34 KB 4.34 KB 1.4 KB 1.4 KB NODE_DEV
react-interactions-events/context-menu.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 668 B 667 B NODE_PROD
react-interactions-events/input.production.min.js 0.0% -0.1% 1.66 KB 1.66 KB 917 B 916 B NODE_PROD
react-interactions-events/scroll.production.min.js 0.0% -0.1% 2.44 KB 2.44 KB 1.09 KB 1.09 KB NODE_PROD
react-interactions-events/hover.development.js 0.0% -0.1% 7 KB 7 KB 1.56 KB 1.55 KB UMD_DEV
react-interactions-events/press-legacy.development.js +18.6% +25.7% 20.74 KB 24.6 KB 4.83 KB 6.07 KB UMD_DEV
react-interactions-events/press-legacy.production.min.js 🔺+4.7% 🔺+5.3% 6.98 KB 7.31 KB 2.63 KB 2.77 KB UMD_PROD
react-interactions-events/hover.development.js 0.0% -0.1% 6.82 KB 6.82 KB 1.51 KB 1.51 KB NODE_DEV
react-interactions-events/press-legacy.development.js +18.8% +25.8% 20.55 KB 24.41 KB 4.78 KB 6.02 KB NODE_DEV
react-interactions-accessibility/focus-table.development.js 0.0% -0.1% 6.97 KB 6.97 KB 1.65 KB 1.64 KB NODE_DEV
react-interactions-events/press-legacy.production.min.js 🔺+4.8% 🔺+5.4% 6.8 KB 7.13 KB 2.57 KB 2.71 KB NODE_PROD
ReactEventsPressLegacy-prod.js 🔺+3.3% 🔺+5.0% 16.2 KB 16.74 KB 3.56 KB 3.73 KB FB_WWW_PROD
react-interactions-events/focus.development.js 0.0% -0.1% 10.74 KB 10.74 KB 2.32 KB 2.32 KB NODE_DEV
react-interactions-events/press.development.js +81.5% +91.4% 4.74 KB 8.6 KB 1.36 KB 2.59 KB NODE_DEV
react-interactions-events/focus.production.min.js 0.0% -0.1% 3.93 KB 3.93 KB 1.32 KB 1.32 KB NODE_PROD
react-interactions-events/press.production.min.js 🔺+14.6% 🔺+15.9% 1.96 KB 2.24 KB 888 B 1 KB NODE_PROD
react-interactions-events/drag.development.js 0.0% -0.1% 5.23 KB 5.23 KB 1.54 KB 1.54 KB UMD_DEV
react-interactions-events/keyboard.development.js 0.0% -0.0% 5.75 KB 5.75 KB 2.14 KB 2.14 KB UMD_DEV
react-interactions-events/swipe.development.js 0.0% +0.1% 6 KB 6 KB 1.62 KB 1.63 KB UMD_DEV
react-interactions-events/keyboard.production.min.js 0.0% -0.1% 2.41 KB 2.41 KB 1.21 KB 1.21 KB UMD_PROD
ReactEventsPress-dev.js +49.2% +62.2% 4.69 KB 7 KB 1.32 KB 2.14 KB FB_WWW_DEV
react-interactions-events/swipe.production.min.js 0.0% 🔺+0.1% 2.45 KB 2.45 KB 1.1 KB 1.11 KB UMD_PROD
ReactEventsPress-prod.js 🔺+11.1% 🔺+15.9% 3.97 KB 4.41 KB 1.06 KB 1.23 KB FB_WWW_PROD
react-interactions-events/keyboard.production.min.js 0.0% -0.1% 2.23 KB 2.23 KB 1.16 KB 1.16 KB NODE_PROD
react-interactions-accessibility/tabbable-scope.production.min.js 0.0% -0.2% 680 B 680 B 447 B 446 B NODE_PROD

Generated by 🚫 dangerJS against 2ef1bc7

@trueadm trueadm merged commit 1758b3f into facebook:master Sep 23, 2019
@trueadm trueadm deleted the react-prevent-default branch September 23, 2019 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants