expose isHydrating

[lunaruan]

Added a function on ReactFiberHydrationContext to expose isHydrating in ReactDOMFB

[sizebot]

ReactDOM: size: 0.0%, gzip: 0.0%

Details of bundled changes.

Comparing: 911104a...95d4234

react-dom

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
react-dom.profiling.min.js	0.0%	0.0%	120.77 KB	120.77 KB	38.01 KB	38.01 KB	NODE_PROFILING
react-dom-server.browser.development.js	0.0%	0.0%	142.17 KB	142.17 KB	37.13 KB	37.13 KB	UMD_DEV
ReactDOM-dev.js	0.0%	+0.1%	978.23 KB	978.26 KB	215.84 KB	216 KB	FB_WWW_DEV
react-dom-server.browser.production.min.js	0.0%	0.0%	19.86 KB	19.86 KB	7.37 KB	7.37 KB	UMD_PROD
react-dom-unstable-fizz.browser.development.js	0.0%	+0.1%	3.78 KB	3.78 KB	1.53 KB	1.53 KB	UMD_DEV
react-dom-test-utils.production.min.js	0.0%	0.0%	11.19 KB	11.19 KB	4.16 KB	4.16 KB	UMD_PROD
react-dom-test-utils.production.min.js	0.0%	🔺+0.1%	10.96 KB	10.96 KB	4.09 KB	4.09 KB	NODE_PROD
react-dom-unstable-fizz.browser.production.min.js	0.0%	🔺+0.2%	1.04 KB	1.04 KB	633 B	634 B	NODE_PROD
react-dom.development.js	0.0%	0.0%	952.72 KB	952.72 KB	214.87 KB	214.88 KB	UMD_DEV
react-dom.production.min.js	0.0%	0.0%	117.08 KB	117.08 KB	37.68 KB	37.69 KB	UMD_PROD
react-dom.profiling.min.js	0.0%	0.0%	120.6 KB	120.6 KB	38.7 KB	38.7 KB	UMD_PROFILING
react-dom.development.js	0.0%	0.0%	946.77 KB	946.77 KB	213.33 KB	213.33 KB	NODE_DEV
react-dom-server.node.development.js	0.0%	0.0%	139.12 KB	139.12 KB	36.36 KB	36.36 KB	NODE_DEV
react-dom.production.min.js	0.0%	0.0%	117.1 KB	117.1 KB	36.96 KB	36.96 KB	NODE_PROD
react-dom-server.node.production.min.js	0.0%	0.0%	20.2 KB	20.2 KB	7.52 KB	7.52 KB	NODE_PROD
ReactDOM-prod.js	🔺+0.3%	🔺+0.6%	393.61 KB	394.93 KB	71.6 KB	72.03 KB	FB_WWW_PROD
ReactDOM-profiling.js	-0.0%	+0.6%	399.72 KB	399.71 KB	72.68 KB	73.09 KB	FB_WWW_PROFILING
react-dom-server.browser.development.js	0.0%	0.0%	138.1 KB	138.1 KB	36.13 KB	36.13 KB	NODE_DEV
react-dom-server.browser.production.min.js	0.0%	0.0%	19.79 KB	19.79 KB	7.36 KB	7.36 KB	NODE_PROD
react-dom-unstable-native-dependencies.development.js	0.0%	0.0%	60.73 KB	60.73 KB	15.85 KB	15.85 KB	UMD_DEV
react-dom-unstable-native-dependencies.production.min.js	0.0%	0.0%	10.74 KB	10.74 KB	3.67 KB	3.67 KB	UMD_PROD
ReactDOMServer-prod.js	0.0%	0.0%	48.55 KB	48.55 KB	11.13 KB	11.13 KB	FB_WWW_PROD
react-dom-unstable-native-dependencies.production.min.js	0.0%	0.0%	10.49 KB	10.49 KB	3.57 KB	3.57 KB	NODE_PROD

Generated by 🚫 dangerJS against 95d4234

[gaearon]

Sure. Any reason we don't want to expose it on the reconciler interface, similar to findHostInstance?

[lunaruan]

This change is most likely just going to be temporary and only used in one place, so it seemed easier to put it on the SECRET_INTERNALS object for now so it can also be easily removed. Also, it makes it (hopefully) less likely people will use it. Longer term, I think we (@sebmck) want to expose a hook rather than this field for users.

Also, if we put this field only on ReactDomFB, only FB will be able to access it, whereas if we put it anywhere else we potentially are exposing it in other places