Skip to content

/ react

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move eventSystemFlags to last argument in event plugin extractors #16978

Merged
merged 1 commit into from Oct 2, 2019
Merged

Move eventSystemFlags to last argument in event plugin extractors #16978

merged 1 commit into from Oct 2, 2019

Conversation

@necolas
Copy link
Contributor

@necolas necolas commented Oct 1, 2019

Fix for necolas/react-native-web#1443
@necolas necolas requested review from bvaughn and sebmarkbage Oct 1, 2019
@sizebot
Copy link

@sizebot sizebot commented Oct 1, 2019 •
edited

ReactDOM: size: 0.0%, gzip: 0.0%

Details of bundled changes.

Comparing: f6efb22...6571808

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js -0.0% 0.0% 121.07 KB 121.06 KB 38.19 KB 38.19 KB NODE_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 140.87 KB 140.87 KB 36.91 KB 36.91 KB UMD_DEV
ReactDOM-dev.js 0.0% 0.0% 976.14 KB 976.14 KB 216.52 KB 216.54 KB FB_WWW_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 19.86 KB 19.86 KB 7.38 KB 7.38 KB UMD_PROD
react-dom-test-utils.development.js 0.0% 0.0% 56.94 KB 56.94 KB 15.7 KB 15.7 KB UMD_DEV
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.78 KB 3.78 KB 1.53 KB 1.53 KB UMD_DEV
ReactDOMUnstableNativeDependencies-dev.js 0.0% 0.0% 58.7 KB 58.7 KB 14.86 KB 14.86 KB FB_WWW_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.3% 1.2 KB 1.2 KB 701 B 703 B UMD_PROD
ReactDOMUnstableNativeDependencies-prod.js 🔺+0.2% -0.1% 26.05 KB 26.1 KB 5.28 KB 5.27 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% 0.0% 55.21 KB 55.21 KB 15.37 KB 15.37 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.61 KB 3.61 KB 1.48 KB 1.48 KB NODE_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.3% 1.04 KB 1.04 KB 632 B 634 B NODE_PROD
react-dom.development.js 0.0% -0.0% 951.68 KB 951.68 KB 215.44 KB 215.43 KB UMD_DEV
react-dom.production.min.js -0.0% -0.0% 117.32 KB 117.31 KB 37.84 KB 37.84 KB UMD_PROD
react-dom.profiling.min.js -0.0% 0.0% 120.85 KB 120.85 KB 38.87 KB 38.87 KB UMD_PROFILING
react-dom.development.js 0.0% -0.0% 945.72 KB 945.72 KB 213.89 KB 213.88 KB NODE_DEV
react-dom-server.node.development.js 0.0% 0.0% 137.88 KB 137.88 KB 36.15 KB 36.15 KB NODE_DEV
react-dom.production.min.js -0.0% -0.0% 117.42 KB 117.42 KB 37.16 KB 37.15 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% 0.0% 20.2 KB 20.2 KB 7.52 KB 7.52 KB NODE_PROD
ReactDOM-prod.js -0.1% -0.0% 400.33 KB 400 KB 73.05 KB 73.05 KB FB_WWW_PROD
ReactDOM-profiling.js -0.1% -0.0% 401.14 KB 400.81 KB 73.56 KB 73.56 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 136.8 KB 136.8 KB 35.92 KB 35.92 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 19.79 KB 19.79 KB 7.36 KB 7.36 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.53 KB 60.53 KB 15.83 KB 15.84 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.2% 10.74 KB 10.75 KB 3.67 KB 3.68 KB UMD_PROD
ReactDOMServer-dev.js 0.0% 0.0% 140.69 KB 140.69 KB 35.48 KB 35.48 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% 0.0% 48.24 KB 48.24 KB 11.04 KB 11.04 KB FB_WWW_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.2 KB 60.2 KB 15.71 KB 15.71 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 3.87 KB 3.87 KB 1.51 KB 1.51 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 10.49 KB 10.49 KB 3.57 KB 3.57 KB NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.3% 1.1 KB 1.1 KB 666 B 668 B NODE_PROD

Generated by 🚫 dangerJS against 6571808

@bvaughn
bvaughn approved these changes Oct 1, 2019
View changes
@necolas
Move eventSystemFlags to last argument in event plugin extractors
Loading status checks…
6571808
@necolas necolas force-pushed the necolas:react/fix-extract-events-args-order branch from 662d18b to 6571808 Oct 1, 2019
@necolas necolas merged commit ab1a4f2 into facebook:master Oct 2, 2019
13 checks passed
13 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: flow Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint_build Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_build Your tests passed on CircleCI!
Details
ci/circleci: test_build_devtools Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: test_dom_fixtures Your tests passed on CircleCI!
Details
ci/circleci: test_source Your tests passed on CircleCI!
Details
ci/circleci: test_source_persistent Your tests passed on CircleCI!
Details
ci/circleci: test_source_prod Your tests passed on CircleCI!
Details
acdlite added a commit to acdlite/react that referenced this pull request Oct 3, 2019
@necolas @acdlite
Move eventSystemFlags to last argument in event plugin extractors (fa…
Loading status checks…
4ab6305 
…cebook#16978)

Fix for necolas/react-native-web#1443
@acdlite acdlite mentioned this pull request Oct 3, 2019
Closed
1 of 1 task complete
This was referenced Oct 12, 2019
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Merged
Merged
This was referenced Oct 19, 2019
Open
Merged
Merged
Merged
Open
Open
Open
Open
This was referenced Apr 14, 2020
Open
Open
Open
Open
Open
Open
Open
Merged
Merged
Closed
This was referenced Apr 21, 2020
Open
Closed
Open
Open
Merged
Closed
Open
Open
Closed
Open
Open
This was referenced Apr 30, 2020
Open
Open
Open
Closed
Merged
Open
Closed
Open
@snyk-bot snyk-bot mentioned this pull request May 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvaughn bvaughn

@sebmarkbage sebmarkbage

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@necolas @sizebot @bvaughn @facebook-github-bot
You can’t perform that action at this time.