Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Portals When they aren't wrapped in a host component when Parent Suspends #16992

Merged
merged 2 commits into from
Oct 2, 2019

Conversation

lunaruan
Copy link
Contributor

@lunaruan lunaruan commented Oct 2, 2019

Currently, when a node suspends, if its subtree contains a portal, the portal is not hidden. This hides portals in the subtree when it's not wrapped in a host component .

@sizebot
Copy link

sizebot commented Oct 2, 2019

Details of bundled changes.

Comparing: 10277cc...e31a360

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js 0.0% 0.0% 669.15 KB 669.39 KB 145.49 KB 145.51 KB UMD_DEV
react-art.production.min.js 🔺+0.1% 🔺+0.1% 103.87 KB 104 KB 31.61 KB 31.63 KB UMD_PROD
react-art.development.js 0.0% 0.0% 599.78 KB 600.02 KB 128.08 KB 128.1 KB NODE_DEV
react-art.production.min.js 🔺+0.2% 🔺+0.2% 68.89 KB 69.01 KB 20.89 KB 20.92 KB NODE_PROD
ReactART-dev.js 0.0% 0.0% 614.49 KB 614.73 KB 127.91 KB 127.93 KB FB_WWW_DEV
ReactART-prod.js 🔺+0.2% 🔺+0.2% 231.33 KB 231.72 KB 39.07 KB 39.13 KB FB_WWW_PROD

Generated by 🚫 dangerJS against e31a360

@lunaruan lunaruan merged commit de2edc2 into facebook:master Oct 2, 2019
@lunaruan lunaruan deleted the hide_portal_container branch October 2, 2019 22:31
lunaruan added a commit that referenced this pull request Oct 4, 2019
lunaruan added a commit that referenced this pull request Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants