Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-interactions] Remove context.setTimeout & context.clearTimeout #17000

Merged
merged 1 commit into from
Oct 3, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Oct 3, 2019

This PR aims at reducing some of the size of the new responder event system. We have the concept of setTimeout and clearTimeout on responder context to handle async timers. This was used a while ago, but we removed any usage it from the event responder and thus have no real need to keep the code around anymore.

@sizebot
Copy link

sizebot commented Oct 3, 2019

Details of bundled changes.

Comparing: f6efb22...c2e5263

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js -0.0% -0.0% 121.07 KB 121.06 KB 38.19 KB 38.19 KB NODE_PROFILING
ReactDOM-dev.js -0.2% -0.2% 976.14 KB 973.93 KB 216.52 KB 216.1 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% 0.0% 56.94 KB 56.94 KB 15.7 KB 15.7 KB UMD_DEV
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.78 KB 3.78 KB 1.53 KB 1.53 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 11.19 KB 11.19 KB 4.16 KB 4.16 KB UMD_PROD
react-dom-test-utils.production.min.js 0.0% 0.0% 10.96 KB 10.96 KB 4.09 KB 4.09 KB NODE_PROD
react-dom.development.js -0.2% -0.2% 951.68 KB 949.48 KB 215.44 KB 214.98 KB UMD_DEV
react-dom.production.min.js -0.0% -0.0% 117.32 KB 117.3 KB 37.84 KB 37.84 KB UMD_PROD
react-dom.profiling.min.js -0.0% -0.0% 120.85 KB 120.84 KB 38.87 KB 38.87 KB UMD_PROFILING
react-dom.development.js -0.2% -0.2% 945.72 KB 943.52 KB 213.89 KB 213.42 KB NODE_DEV
react-dom-server.node.development.js 0.0% 0.0% 137.88 KB 137.88 KB 36.15 KB 36.15 KB NODE_DEV
react-dom.production.min.js -0.0% -0.0% 117.42 KB 117.41 KB 37.16 KB 37.16 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% 0.0% 20.2 KB 20.2 KB 7.52 KB 7.52 KB NODE_PROD
ReactDOM-prod.js -0.5% -0.6% 400.33 KB 398.23 KB 73.05 KB 72.64 KB FB_WWW_PROD
ReactDOM-profiling.js -0.5% -0.5% 401.14 KB 399.04 KB 73.56 KB 73.15 KB FB_WWW_PROFILING
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.53 KB 60.53 KB 15.83 KB 15.83 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 10.74 KB 10.74 KB 3.67 KB 3.67 KB UMD_PROD
ReactDOMServer-prod.js 0.0% 0.0% 48.24 KB 48.24 KB 11.04 KB 11.04 KB FB_WWW_PROD
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 3.87 KB 3.87 KB 1.51 KB 1.51 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 10.49 KB 10.49 KB 3.57 KB 3.57 KB NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.2% 1.1 KB 1.1 KB 666 B 667 B NODE_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-prod.js 0.0% 0.0% 276.18 KB 276.18 KB 47.2 KB 47.21 KB RN_OSS_PROD
ReactFabric-prod.js -0.0% -0.0% 267.26 KB 267.24 KB 45.78 KB 45.77 KB RN_OSS_PROD
ReactFabric-profiling.js -0.0% -0.0% 277.9 KB 277.88 KB 47.63 KB 47.63 KB RN_OSS_PROFILING
ReactFabric-dev.js -0.3% -0.3% 753.38 KB 751.38 KB 159.42 KB 159.01 KB RN_FB_DEV
ReactFabric-prod.js -0.0% -0.0% 267.26 KB 267.24 KB 45.79 KB 45.79 KB RN_FB_PROD
ReactNativeRenderer-dev.js 0.0% 0.0% 747.33 KB 747.33 KB 158.4 KB 158.4 KB RN_OSS_DEV
ReactFabric-profiling.js -0.0% -0.0% 277.9 KB 277.88 KB 47.64 KB 47.64 KB RN_FB_PROFILING
ReactNativeRenderer-dev.js 0.0% 0.0% 747.49 KB 747.49 KB 158.47 KB 158.47 KB RN_FB_DEV
ReactNativeRenderer-profiling.js 0.0% -0.0% 285.71 KB 285.71 KB 48.92 KB 48.92 KB RN_FB_PROFILING
ReactFabric-dev.js -0.3% -0.3% 753.21 KB 751.21 KB 159.34 KB 158.94 KB RN_OSS_DEV

Generated by 🚫 dangerJS against c2e5263

@trueadm trueadm merged commit 4c56984 into facebook:master Oct 3, 2019
@trueadm trueadm deleted the clean-up-flare branch October 3, 2019 11:40
@necolas
Copy link
Contributor

necolas commented Oct 3, 2019

It would be needed by LongPress

@trueadm
Copy link
Contributor Author

trueadm commented Oct 3, 2019

We can handle timers in the component rather than in the responder, which allows us to possibly use the scheduler cc @acdlite.

@necolas
Copy link
Contributor

necolas commented Oct 3, 2019

In what component? LongPress is inherently related to timers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants