-
Notifications
You must be signed in to change notification settings - Fork 46.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[react-interactions] Remove context.setTimeout & context.clearTimeout #17000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70ac61a
to
f8d456d
Compare
Details of bundled changes.Comparing: f6efb22...c2e5263 react-dom
react-native-renderer
|
Extract errors Remove unused var
4e8c2d3
to
c2e5263
Compare
threepointone
approved these changes
Oct 3, 2019
It would be needed by LongPress |
We can handle timers in the component rather than in the responder, which allows us to possibly use the scheduler cc @acdlite. |
In what component? LongPress is inherently related to timers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at reducing some of the size of the new responder event system. We have the concept of
setTimeout
andclearTimeout
on responder context to handle async timers. This was used a while ago, but we removed any usage it from the event responder and thus have no real need to keep the code around anymore.