Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make uncontrolled -> controlled warning clearer #17070

Merged
merged 7 commits into from
Apr 7, 2020
Merged

Conversation

vcarl
Copy link
Contributor

@vcarl vcarl commented Oct 11, 2019

Fixes #17069. Glad to iterate further on the specific language, but I've found that explaining in this way usually clears it up for people.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@sizebot
Copy link

sizebot commented Oct 11, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS against eb7d88f

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@markerikson
Copy link
Contributor

I would suggest adding a sentence like "This is likely caused by value={something} changing from undefined to a defined value".

@sophiebits
Copy link
Collaborator

  • The %s placeholder here is not the value type but rather the input type (checkbox, radio, etc). However I don’t think we need this info any more since we have robust component stacks in warnings. So let’s just remove that substitution and say “undefined value”.
  • You’ll need to update any tests that are verifying this warning message.
  • Other than that, this is a great improvement! Any chance you can make the above improvements? Then this can be merged.

@vcarl
Copy link
Contributor Author

vcarl commented Jan 2, 2020

Looks like this was upgraded to an error since I opened the PR. Fixing conflicts.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 2, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dbe2dcc:

Sandbox Source
cool-mountain-7k3dq Configuration

@sizebot
Copy link

sizebot commented Jan 2, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against dbe2dcc

@sizebot
Copy link

sizebot commented Jan 2, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against dbe2dcc

@vcarl
Copy link
Contributor Author

vcarl commented Jan 7, 2020

No rush on this, but anything else needed for it to land? cc @sophiebits @gaearon

@stale
Copy link

stale bot commented Apr 7, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Apr 7, 2020
@vcarl vcarl closed this Apr 7, 2020
@vcarl vcarl deleted the patch-1 branch April 7, 2020 15:57
@gaearon
Copy link
Collaborator

gaearon commented Apr 7, 2020

@vcarl Sorry, there's a huge backlog and things slip through. I wanted to merge this but now the ref is gone. :-(

@vcarl vcarl restored the patch-1 branch April 7, 2020 20:45
@vcarl
Copy link
Contributor Author

vcarl commented Apr 7, 2020

I restored the branch, but am unsubscribing from the PR. If it lands, cool! But I'm moving on.

@gaearon gaearon reopened this Apr 7, 2020
@stale stale bot removed the Resolution: Stale Automatically closed due to inactivity label Apr 7, 2020
@gaearon gaearon merged commit 03de849 into facebook:master Apr 7, 2020
@gaearon
Copy link
Collaborator

gaearon commented Apr 7, 2020

Thanks!

This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The warning for uncontrolled -> controlled inputs is confusing
6 participants