Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make uncontrolled -> controlled warning clearer #17070

Merged
merged 7 commits into from Apr 7, 2020
Merged

Conversation

@vcarl
Copy link
Contributor

@vcarl vcarl commented Oct 11, 2019

Fixes #17069. Glad to iterate further on the specific language, but I've found that explaining in this way usually clears it up for people.

@facebook-github-bot
Copy link

@facebook-github-bot facebook-github-bot commented Oct 11, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@sizebot
Copy link

@sizebot sizebot commented Oct 11, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS against eb7d88f

@facebook-github-bot
Copy link

@facebook-github-bot facebook-github-bot commented Oct 11, 2019

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@markerikson
Copy link

@markerikson markerikson commented Oct 16, 2019

I would suggest adding a sentence like "This is likely caused by value={something} changing from undefined to a defined value".

@sophiebits
Copy link
Collaborator

@sophiebits sophiebits commented Jan 1, 2020

  • The %s placeholder here is not the value type but rather the input type (checkbox, radio, etc). However I don’t think we need this info any more since we have robust component stacks in warnings. So let’s just remove that substitution and say “undefined value”.
  • You’ll need to update any tests that are verifying this warning message.
  • Other than that, this is a great improvement! Any chance you can make the above improvements? Then this can be merged.
vcarl added 4 commits Jan 2, 2020
@vcarl
Copy link
Contributor Author

@vcarl vcarl commented Jan 2, 2020

Looks like this was upgraded to an error since I opened the PR. Fixing conflicts.

@codesandbox
Copy link

@codesandbox codesandbox bot commented Jan 2, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dbe2dcc:

Sandbox Source
cool-mountain-7k3dq Configuration
@sizebot
Copy link

@sizebot sizebot commented Jan 2, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against dbe2dcc

@sizebot
Copy link

@sizebot sizebot commented Jan 2, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against dbe2dcc

@vcarl
Copy link
Contributor Author

@vcarl vcarl commented Jan 7, 2020

No rush on this, but anything else needed for it to land? cc @sophiebits @gaearon

@stale
Copy link

@stale stale bot commented Apr 7, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution.

@stale stale bot added the Resolution: Stale label Apr 7, 2020
@vcarl vcarl closed this Apr 7, 2020
@vcarl vcarl deleted the vcarl:patch-1 branch Apr 7, 2020
@gaearon
Copy link
Member

@gaearon gaearon commented Apr 7, 2020

@vcarl Sorry, there's a huge backlog and things slip through. I wanted to merge this but now the ref is gone. :-(

@vcarl vcarl restored the vcarl:patch-1 branch Apr 7, 2020
@vcarl
Copy link
Contributor Author

@vcarl vcarl commented Apr 7, 2020

I restored the branch, but am unsubscribing from the PR. If it lands, cool! But I'm moving on.

@gaearon gaearon reopened this Apr 7, 2020
@stale stale bot removed the Resolution: Stale label Apr 7, 2020
@gaearon gaearon merged commit 03de849 into facebook:master Apr 7, 2020
22 checks passed
22 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_devtools_and_process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: build_experimental Your tests passed on CircleCI!
Details
ci/circleci: flow Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint_build Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts_experimental Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: sizebot Your tests passed on CircleCI!
Details
ci/circleci: sizebot_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build Your tests passed on CircleCI!
Details
ci/circleci: test_build_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_devtools Your tests passed on CircleCI!
Details
ci/circleci: test_dom_fixtures Your tests passed on CircleCI!
Details
ci/circleci: test_source Your tests passed on CircleCI!
Details
ci/circleci: test_source_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_source_persistent Your tests passed on CircleCI!
Details
ci/circleci: test_source_prod Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
@gaearon
Copy link
Member

@gaearon gaearon commented Apr 7, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants
You can’t perform that action at this time.