[babel-plugin-react-jsx] Avoid duplicate "children" key in props object #17094
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a duplicate "children" key bug in the
TransformJSXToReactJSX
Babel transform. Specifically, when we have JSX that looks like this:Before this PR, the output would have been:
In the above output, the
children
property is duplicated in the object literal expression. In JS strict mode, this can cause errors in certain browsers (notably IE) where an object cannot contain duplicate property keys.This PR changed the logic, so when this pattern is encountered (explicitly with
children
only) we create a new object and put thechildren
property in it and then useObject.assign
(or whatever the native helper is) to ensure the correct object is formed as an end-result. So the above would output: