Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary patch www fork with prefixed APIs #17103

Merged
merged 1 commit into from
Oct 15, 2019

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Oct 15, 2019

I'm doing this here instead of in the downstream repo so that if the sync diff gets reverted, it doesn't revert this, too.

Once the sync has landed, and the callers are updated in www, I will remove this.

I'm doing this here instead of in the downstream repo so that if the
sync diff gets reverted, it doesn't revert this, too.

Once the sync has landed, and the callers are updated in www, I will
remove this.
@sizebot
Copy link

sizebot commented Oct 15, 2019

ReactDOM: size: 0.0%, gzip: -0.0%

Details of bundled changes.

Comparing: 30c5daf...2fdd73d

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js 0.0% -0.0% 118.89 KB 118.89 KB 37.56 KB 37.56 KB NODE_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 140 KB 140 KB 36.78 KB 36.79 KB UMD_DEV
ReactDOM-dev.js 0.0% 0.0% 968.38 KB 968.74 KB 215.28 KB 215.36 KB FB_WWW_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 19.83 KB 19.83 KB 7.36 KB 7.36 KB UMD_PROD
react-dom-test-utils.development.js 0.0% -0.0% 56.26 KB 56.26 KB 15.57 KB 15.57 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.1% 11.17 KB 11.17 KB 4.14 KB 4.14 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 701 B 700 B UMD_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 10.94 KB 10.94 KB 4.08 KB 4.08 KB NODE_PROD
react-dom.development.js 0.0% -0.0% 946.35 KB 946.35 KB 214.42 KB 214.42 KB UMD_DEV
react-dom.production.min.js 0.0% -0.0% 115.13 KB 115.13 KB 37.1 KB 37.1 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 118.66 KB 118.66 KB 38.23 KB 38.23 KB UMD_PROFILING
react-dom.development.js 0.0% -0.0% 940.41 KB 940.41 KB 212.84 KB 212.84 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 115.24 KB 115.24 KB 36.54 KB 36.54 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% -0.0% 20.17 KB 20.17 KB 7.5 KB 7.5 KB NODE_PROD
ReactDOM-prod.js 🔺+0.1% 🔺+0.1% 396.2 KB 396.49 KB 72.15 KB 72.2 KB FB_WWW_PROD
ReactDOM-profiling.js +0.1% +0.1% 396.93 KB 397.21 KB 72.65 KB 72.71 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 135.93 KB 135.93 KB 35.78 KB 35.78 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 19.76 KB 19.76 KB 7.35 KB 7.35 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.13 KB 60.13 KB 15.79 KB 15.79 KB UMD_DEV
ReactDOMServer-dev.js 0.0% -0.0% 139.28 KB 139.28 KB 35.32 KB 35.32 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% -0.0% 48.49 KB 48.49 KB 11.07 KB 11.07 KB FB_WWW_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 59.8 KB 59.8 KB 15.66 KB 15.65 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 3.87 KB 3.87 KB 1.51 KB 1.51 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.46 KB 10.46 KB 3.57 KB 3.56 KB NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% -0.1% 1.1 KB 1.1 KB 667 B 666 B NODE_PROD

Generated by 🚫 dangerJS against 2fdd73d

@acdlite acdlite merged commit 4356245 into facebook:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants