[Fresh] Fix an infinite loop in an edge case #17414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9fe214a:
|
Details of bundled changes.Comparing: a7d07ff...9fe214a react-refresh
Size changes (stable) |
Details of bundled changes.Comparing: a7d07ff...9fe214a react-refresh
Size changes (experimental) |
nihgwu
reviewed
Nov 21, 2019
| // If we don't do this, there is a risk they will be mutated while | ||
| // we iterate over them. For example, trying to recover a failed root | ||
| // may cause another root to be added to the failed list -- an infinite loop. | ||
| let failedRootsSnapshot = new Map(failedRoots); |
There was a problem hiding this comment.
is it supposed that new Map([iterable]) is polyfilled in react-refresh
There was a problem hiding this comment.
Would IE11 be the only one that can’t do it? I guess we could use something longer but tbh I don’t know if we care about supporting IE11 for a developer productivity feature like this.
threepointone
approved these changes
Nov 21, 2019
|
Ouch, a classic bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A good old mutation-while-iterating kind of bug. These maps and sets can be mutated during a commit, so we can't just
forEachhere. Otherwise we risk running into an infinite loop where processing each next item causes more items to be added to the list.Added a regression test. Verified this fixes a problem on WWW.