Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React Devtools Component: Add hotkeys to start inspecting node #17473

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

React Devtools Component: Add hotkeys to start inspecting node #17473

wants to merge 1 commit into from

Conversation

gejimayu
Copy link

@gejimayu gejimayu commented Nov 27, 2019 •
edited

Issue is here #17298

Hotkey: Cmd Shift X (mac) or Ctrl Shift X (others)

hotkey

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 27, 2019 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 76432ba:

Sandbox Source
strange-flower-bfntv Configuration

@sizebot
Copy link

sizebot commented Nov 27, 2019 •
edited

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 76432ba

@sizebot
Copy link

sizebot commented Nov 27, 2019 •
edited

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 76432ba

@gejimayu gejimayu force-pushed the gianfranco/react-devtools-component-add-hotkeys-for-inspecting-node branch from c54f636 to cd135a2 Compare November 27, 2019 10:50
@gejimayu
Copy link
Author

@bvaughn may i have your review? thanks in advance

@gejimayu gejimayu force-pushed the gianfranco/react-devtools-component-add-hotkeys-for-inspecting-node branch from cd135a2 to 673b477 Compare November 29, 2019 09:25
@gejimayu gejimayu force-pushed the gianfranco/react-devtools-component-add-hotkeys-for-inspecting-node branch from 673b477 to 76432ba Compare November 29, 2019 09:49
@stale
Copy link

stale bot commented Apr 28, 2020

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Apr 28, 2020
@stale stale bot removed the Resolution: Stale Automatically closed due to inactivity label May 2, 2020
@stale
Copy link

stale bot commented Aug 1, 2020

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Aug 1, 2020
@eps1lon
Copy link
Collaborator

eps1lon commented Aug 1, 2020

I'm interested in this feature. Didn't monitor the underlying issue which was closed by stale bot.

@stale stale bot removed the Resolution: Stale Automatically closed due to inactivity label Aug 1, 2020
@gejimayu
Copy link
Author

gejimayu commented Aug 2, 2020

yes please review and approve/merge if you think it's good, thanks

@happylolonly
Copy link

happylolonly commented Jan 14, 2021 •
edited

@awibox @53jk1 and others, please merge it, I also want this feature;) Thanks!

1,5 years, why haven't merged?

@eps1lon eps1lon mentioned this pull request Jan 14, 2021
Open
@kbakdev
Copy link

kbakdev commented Apr 18, 2021

I'm not a collaborator, sorry.

@bvaughn bvaughn changed the base branch from master to main July 15, 2021 00:43
@stale
Copy link

stale bot commented Jan 9, 2022

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Jan 9, 2022
@happylolonly
Copy link

@awibox @53jk1 and others, please merge it, I also want this feature;) Thanks!

1,5 years, why haven't merged?

😴

@stale stale bot removed the Resolution: Stale Automatically closed due to inactivity label Jan 11, 2022
@joshmu
Copy link

joshmu commented Jan 31, 2022

bump

@happylolonly
Copy link

happylolonly commented Feb 4, 2022 •
edited

Very difficult issue;)

@tondi
Copy link

tondi commented Apr 21, 2022

bump

@Vooord
Copy link

Vooord commented May 17, 2023 •
edited

Any progress in here? :)

Still relevant, even though this comment partially helped me:

An easy workaround for this is to use the normal element selector (Ctrl-shift-C) and then switch to the Components tab, where the corresponding React component (or something close to it) will be selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awibox awibox awibox approved these changes

@bl00mber bl00mber bl00mber approved these changes

@jawadulhassan jawadulhassan jawadulhassan approved these changes

@kbakdev kbakdev kbakdev approved these changes

Assignees
No one assigned
Labels
CLA Signed Component: Developer Tools Type: Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet