Fix comments typos #17550
Merged
Fix comments typos #17550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4a884ae:
|
gc
suggested changes
Dec 11, 2019
| @@ -728,7 +728,7 @@ function updateClassComponent( | |||
| if (instance === null) { | |||
| if (current !== null) { | |||
| // An class component without an instance only mounts if it suspended | |||
| // inside a non- concurrent tree, in an inconsistent state. We want to | |||
| // inside a non-concurrent tree, in an inconsistent state. We want to | |||
| // tree it like a new mount, even though an empty version of it already | |||
There was a problem hiding this comment.
Good catch. Just fixed that.
jawadulhassan
approved these changes
Dec 21, 2019
bvaughn
approved these changes
Dec 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating React Reconciler (for personal education) and its main phases:
ReactFiberBeginWork,ReactFiberCommitWorkandReactFiberCompleteWorkI spotted some typos in dev comments and thought I would commit back some of the sensible changes for folks who read comments 😛