Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component stacks to (almost) all warnings #17586

Merged
merged 1 commit into from Dec 12, 2019

Conversation

gaearon
Copy link
Member

@gaearon gaearon commented Dec 12, 2019

As the title says. This adds component stacks to all warnings except the ones where a package doesn't have peer or dep on React (such as react-is). Concretely, we switch over from warningWithoutStack to warning, and from lowPriorityWarningWithoutStack to lowPriorityWarning, wherever possible. Tests are adjusted accordingly.

There are three reasons for this.

  1. Stacks are generally useful. More and consistent is better.
  2. We want to move towards just writing console.error and console.warn in the source code, and having a Babel plugin call the wrapper with extra logic. So it's inconvenient to have this distinction.
  3. Even for warnings that don't currently have stacks, they're actually already being added by React DevTools anyway. So the distinction hasn't mattered for a while.

What if the stack is misleading or not concrete enough? For example, maybe we have a better stack we want to pass. We do the same thing DevTools does in that case. If the last argument already looks like a component stack, we don't append an extra one.

Notably, this adds component stacks to SSR hydration mismatch warnings. They can still sometimes be misleading but it's better than nothing.

Some tests still have {withoutStack: true}. This is not because we can't emit them, but because in those particular tests we're just not inside of a tree. So we're keeping the assertion mechanism for that to avoid regressions.

In a follow-up, I will codemod to console.error / console.warn calls and a Babel plugin for the wrappers. This will also allow us to choose the right version of the wrapper depending on whether a package depends on React or not.

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Dec 12, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1569cad:

Sandbox Source
stupefied-bush-4wy94 Configuration

@sizebot
Copy link

@sizebot sizebot commented Dec 12, 2019

Details of bundled changes.

Comparing: 12c0004...1569cad

react

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react.development.js +1.1% +0.6% 112.66 KB 113.93 KB 28.61 KB 28.77 KB UMD_DEV
react.production.min.js 0.0% 0.0% 12.31 KB 12.31 KB 4.83 KB 4.83 KB UMD_PROD
react.development.js +1.8% +0.9% 72.4 KB 73.67 KB 18.98 KB 19.15 KB NODE_DEV
react.production.min.js 🔺+0.1% 🔺+0.1% 6.51 KB 6.51 KB 2.71 KB 2.71 KB NODE_PROD

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-unstable-native-dependencies.production.min.js 🔺+2.4% 🔺+1.8% 10.46 KB 10.71 KB 3.57 KB 3.63 KB NODE_PROD
react-dom-server.browser.development.js +0.9% +0.3% 135.97 KB 137.25 KB 35.86 KB 35.96 KB NODE_DEV
react-dom.development.js 0.0% +0.1% 950.77 KB 950.85 KB 215.36 KB 215.59 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% 🔺+0.1% 19.85 KB 19.86 KB 7.38 KB 7.38 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.87 KB 3.87 KB 1.54 KB 1.54 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 115.77 KB 115.77 KB 37.42 KB 37.43 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 119.33 KB 119.33 KB 38.53 KB 38.53 KB UMD_PROFILING
react-dom.development.js 0.0% +0.1% 944.83 KB 944.92 KB 213.79 KB 214 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.7 KB 3.7 KB 1.49 KB 1.5 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 115.88 KB 115.88 KB 36.83 KB 36.82 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js +2.7% +2.5% 59.96 KB 61.56 KB 15.72 KB 16.11 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1.04 KB 1.04 KB 633 B 634 B NODE_PROD
react-dom.profiling.min.js 0.0% -0.0% 119.57 KB 119.57 KB 37.82 KB 37.82 KB NODE_PROFILING
react-dom-unstable-native-dependencies.production.min.js 🔺+2.1% 🔺+1.5% 10.72 KB 10.95 KB 3.67 KB 3.72 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js +2.7% +2.8% 59.63 KB 61.27 KB 15.59 KB 16.03 KB NODE_DEV
react-dom-server.node.development.js +0.9% +0.3% 137.08 KB 138.36 KB 36.09 KB 36.19 KB NODE_DEV
react-dom-test-utils.development.js +3.9% +1.6% 55.97 KB 58.13 KB 15.49 KB 15.73 KB UMD_DEV
react-dom-server.node.production.min.js 0.0% 🔺+0.1% 20.26 KB 20.27 KB 7.53 KB 7.53 KB NODE_PROD
react-dom-test-utils.production.min.js 0.0% 0.0% 11.17 KB 11.17 KB 4.14 KB 4.14 KB UMD_PROD
react-dom-test-utils.development.js +4.0% +1.7% 54.24 KB 56.4 KB 15.15 KB 15.41 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 4.4 KB 4.4 KB 1.64 KB 1.64 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 10.94 KB 10.94 KB 4.08 KB 4.08 KB NODE_PROD
react-dom-server.browser.development.js +0.9% +0.3% 140.03 KB 141.31 KB 36.85 KB 36.95 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 690 B 689 B NODE_PROD
react-dom-server.browser.production.min.js 0.0% 🔺+0.1% 19.93 KB 19.93 KB 7.38 KB 7.39 KB UMD_PROD

react-noop-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-noop-renderer.production.min.js 0.0% 🔺+0.1% 11.96 KB 11.96 KB 3.82 KB 3.82 KB NODE_PROD
react-noop-renderer-persistent.development.js +2.9% +2.9% 35.42 KB 36.46 KB 8.05 KB 8.28 KB NODE_DEV
react-noop-renderer-persistent.production.min.js 0.0% 0.0% 11.98 KB 11.98 KB 3.83 KB 3.83 KB NODE_PROD
react-noop-renderer.development.js +2.9% +2.9% 35.31 KB 36.35 KB 8.03 KB 8.26 KB NODE_DEV
react-noop-renderer-server.development.js 0.0% -0.1% 1.97 KB 1.97 KB 899 B 898 B NODE_DEV
react-noop-renderer-flight-client.development.js 0.0% +0.1% 1.62 KB 1.62 KB 771 B 772 B NODE_DEV
react-noop-renderer-flight-client.production.min.js 0.0% 🔺+0.5% 561 B 561 B 413 B 415 B NODE_PROD

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler-persistent.development.js +0.1% +0.2% 599.39 KB 599.87 KB 126.49 KB 126.78 KB NODE_DEV
react-reconciler.development.js +0.1% +0.2% 601.92 KB 602.4 KB 127.58 KB 127.89 KB NODE_DEV
react-reconciler-reflection.development.js +5.6% +3.8% 18.95 KB 20.01 KB 6.18 KB 6.42 KB NODE_DEV

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js +0.1% +0.2% 670.25 KB 670.75 KB 145.82 KB 146.08 KB UMD_DEV
react-art.production.min.js 0.0% 0.0% 104.17 KB 104.17 KB 31.83 KB 31.83 KB UMD_PROD
react-art.development.js +0.1% +0.2% 600.9 KB 601.39 KB 128.41 KB 128.66 KB NODE_DEV
react-art.production.min.js 0.0% 0.0% 69.18 KB 69.18 KB 20.98 KB 20.98 KB NODE_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js +0.1% +0.2% 615.17 KB 615.62 KB 131.48 KB 131.75 KB UMD_DEV
react-test-renderer.development.js +0.1% +0.2% 610.44 KB 610.88 KB 130.28 KB 130.55 KB NODE_DEV
react-test-renderer-shallow.development.js +0.7% +0.8% 38.92 KB 39.18 KB 9.98 KB 10.06 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% 0.0% 11.58 KB 11.58 KB 3.57 KB 3.58 KB UMD_PROD
react-test-renderer-shallow.development.js +0.8% +0.9% 32.87 KB 33.14 KB 8.5 KB 8.58 KB NODE_DEV
react-test-renderer-shallow.production.min.js 0.0% 🔺+0.1% 11.72 KB 11.72 KB 3.68 KB 3.68 KB NODE_PROD

react-cache

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-cache.development.js +18.4% +14.7% 9.05 KB 10.72 KB 3.04 KB 3.49 KB UMD_DEV
react-cache.production.min.js 🔺+9.6% 🔺+5.6% 2.38 KB 2.61 KB 1.21 KB 1.28 KB UMD_PROD
react-cache.development.js +18.9% +14.9% 8.83 KB 10.49 KB 2.97 KB 3.42 KB NODE_DEV
react-cache.production.min.js 🔺+10.4% 🔺+5.3% 2.19 KB 2.42 KB 1.12 KB 1.18 KB NODE_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js 0.0% +0.1% 743.51 KB 743.7 KB 158 KB 158.15 KB RN_FB_DEV
ReactNativeRenderer-prod.js 0.0% 🔺+0.1% 276.52 KB 276.52 KB 47.67 KB 47.7 KB RN_FB_PROD
ReactNativeRenderer-profiling.js 0.0% +0.1% 285.45 KB 285.45 KB 49.4 KB 49.43 KB RN_FB_PROFILING
ReactFabric-dev.js 0.0% +0.1% 748.52 KB 748.73 KB 158.78 KB 158.92 KB RN_FB_DEV
ReactFabric-prod.js 0.0% 🔺+0.1% 268.18 KB 268.18 KB 46.3 KB 46.32 KB RN_FB_PROD
ReactFabric-profiling.js 0.0% +0.1% 278.28 KB 278.28 KB 48.14 KB 48.17 KB RN_FB_PROFILING
ReactNativeRenderer-dev.js 0.0% +0.1% 743.33 KB 743.52 KB 157.92 KB 158.06 KB RN_OSS_DEV
ReactNativeRenderer-prod.js 0.0% 🔺+0.1% 276.13 KB 276.13 KB 47.6 KB 47.63 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 285.06 KB 285.06 KB 49.33 KB 49.35 KB RN_OSS_PROFILING
ReactFabric-dev.js 0.0% +0.1% 748.34 KB 748.55 KB 158.7 KB 158.83 KB RN_OSS_DEV
ReactFabric-prod.js 0.0% 0.0% 267.83 KB 267.83 KB 46.22 KB 46.24 KB RN_OSS_PROD
ReactFabric-profiling.js 0.0% 0.0% 277.94 KB 277.94 KB 48.07 KB 48.09 KB RN_OSS_PROFILING

create-subscription

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
create-subscription.development.js +24.7% +20.2% 6.68 KB 8.33 KB 2.43 KB 2.92 KB NODE_DEV
create-subscription.production.min.js 🔺+11.5% 🔺+11.5% 1.98 KB 2.21 KB 994 B 1.08 KB NODE_PROD

ReactDOM: size: 0.0%, gzip: 0.0%

React: size: 0.0%, gzip: 0.0%

Size changes (stable)

Generated by 🚫 dangerJS against 1569cad

@sizebot
Copy link

@sizebot sizebot commented Dec 12, 2019

Details of bundled changes.

Comparing: 12c0004...1569cad

react

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react.development.js +1.1% +0.5% 112.68 KB 113.95 KB 28.62 KB 28.78 KB UMD_DEV
react.production.min.js 0.0% 🔺+0.1% 12.52 KB 12.52 KB 4.9 KB 4.9 KB UMD_PROD
React-dev.js +2.0% +1.0% 70.6 KB 71.99 KB 18.14 KB 18.32 KB FB_WWW_DEV
React-prod.js 0.0% 🔺+0.1% 17.75 KB 17.75 KB 4.62 KB 4.62 KB FB_WWW_PROD
React-profiling.js 0.0% +0.1% 17.75 KB 17.75 KB 4.62 KB 4.62 KB FB_WWW_PROFILING
react.profiling.min.js 0.0% -0.0% 16.05 KB 16.05 KB 6.01 KB 6.01 KB UMD_PROFILING
react.development.js +1.8% +0.9% 72.43 KB 73.69 KB 18.99 KB 19.16 KB NODE_DEV
react.production.min.js 🔺+0.1% 🔺+0.2% 6.8 KB 6.81 KB 2.81 KB 2.81 KB NODE_PROD

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js 0.0% -0.0% 123.07 KB 123.07 KB 38.81 KB 38.8 KB NODE_PROFILING
react-dom-server.browser.development.js +0.9% +0.3% 140.06 KB 141.34 KB 36.86 KB 36.96 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% 🔺+0.1% 20.39 KB 20.39 KB 7.48 KB 7.48 KB UMD_PROD
react-dom-test-utils.development.js +3.9% +1.6% 55.98 KB 58.14 KB 15.49 KB 15.74 KB UMD_DEV
ReactDOMServer-dev.js +1.0% +0.3% 139.65 KB 141.04 KB 35.43 KB 35.54 KB FB_WWW_DEV
react-dom-test-utils.development.js +4.0% +1.8% 54.26 KB 56.42 KB 15.15 KB 15.42 KB NODE_DEV
ReactDOMServer-prod.js 0.0% 0.0% 48.91 KB 48.91 KB 11.18 KB 11.18 KB FB_WWW_PROD
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.71 KB 3.71 KB 1.5 KB 1.5 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 10.95 KB 10.95 KB 4.09 KB 4.09 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1.05 KB 1.05 KB 641 B 642 B NODE_PROD
react-dom.development.js 0.0% +0.1% 950.79 KB 950.87 KB 215.38 KB 215.61 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 119.11 KB 119.11 KB 38.43 KB 38.43 KB UMD_PROD
ReactDOMUnstableNativeDependencies-dev.js +2.9% +3.9% 58.31 KB 60.01 KB 14.88 KB 15.45 KB FB_WWW_DEV
react-dom.development.js 0.0% +0.1% 944.86 KB 944.94 KB 213.81 KB 214.03 KB NODE_DEV
ReactDOMUnstableNativeDependencies-prod.js 🔺+1.4% 🔺+1.5% 26.11 KB 26.49 KB 5.26 KB 5.34 KB FB_WWW_PROD
react-dom-server.node.development.js +0.9% +0.3% 137.1 KB 138.38 KB 36.09 KB 36.19 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 119.26 KB 119.26 KB 37.76 KB 37.76 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% 🔺+0.1% 20.72 KB 20.73 KB 7.61 KB 7.61 KB NODE_PROD
ReactTestUtils-dev.js +4.4% +3.0% 51.72 KB 54.01 KB 14.02 KB 14.44 KB FB_WWW_DEV
react-dom-server.browser.development.js +0.9% +0.3% 135.99 KB 137.27 KB 35.87 KB 35.96 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% 🔺+0.1% 20.31 KB 20.32 KB 7.46 KB 7.46 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js +2.7% +2.5% 59.97 KB 61.58 KB 15.73 KB 16.12 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 🔺+2.1% 🔺+1.5% 10.73 KB 10.96 KB 3.67 KB 3.73 KB UMD_PROD
ReactDOM-dev.js 0.0% +0.1% 970.44 KB 970.66 KB 216.12 KB 216.44 KB FB_WWW_DEV
react-dom-unstable-native-dependencies.development.js +2.7% +2.8% 59.64 KB 61.28 KB 15.6 KB 16.04 KB NODE_DEV
ReactDOM-profiling.js 0.0% -0.0% 403.72 KB 403.72 KB 74.12 KB 74.11 KB FB_WWW_PROFILING
react-dom-unstable-native-dependencies.production.min.js 🔺+2.4% 🔺+1.8% 10.48 KB 10.73 KB 3.58 KB 3.64 KB NODE_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js +0.1% +0.2% 615.19 KB 615.64 KB 131.49 KB 131.76 KB UMD_DEV
ReactTestRenderer-dev.js +0.1% +0.3% 623.9 KB 624.44 KB 130.51 KB 130.89 KB FB_WWW_DEV
react-test-renderer-shallow.development.js +0.7% +0.8% 38.93 KB 39.2 KB 9.99 KB 10.07 KB UMD_DEV
react-test-renderer-shallow.development.js +0.8% +0.9% 32.88 KB 33.15 KB 8.51 KB 8.59 KB NODE_DEV
react-test-renderer-shallow.production.min.js 0.0% 🔺+0.1% 11.73 KB 11.73 KB 3.69 KB 3.69 KB NODE_PROD
react-test-renderer.development.js +0.1% +0.2% 610.46 KB 610.91 KB 130.29 KB 130.57 KB NODE_DEV
react-test-renderer.production.min.js 0.0% 0.0% 70.93 KB 70.93 KB 21.55 KB 21.55 KB NODE_PROD
ReactShallowRenderer-dev.js +0.8% +0.9% 34.22 KB 34.5 KB 8.46 KB 8.54 KB FB_WWW_DEV

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactFabric-prod.js 0.0% 🔺+0.1% 268.19 KB 268.19 KB 46.31 KB 46.33 KB RN_FB_PROD
ReactNativeRenderer-dev.js 0.0% +0.1% 743.35 KB 743.53 KB 157.92 KB 158.06 KB RN_OSS_DEV
ReactFabric-profiling.js 0.0% +0.1% 278.29 KB 278.29 KB 48.15 KB 48.18 KB RN_FB_PROFILING
ReactNativeRenderer-prod.js 0.0% 🔺+0.1% 276.53 KB 276.53 KB 47.68 KB 47.71 KB RN_FB_PROD
ReactNativeRenderer-profiling.js 0.0% +0.1% 285.46 KB 285.46 KB 49.41 KB 49.44 KB RN_FB_PROFILING
ReactFabric-dev.js 0.0% +0.1% 748.35 KB 748.56 KB 158.7 KB 158.84 KB RN_OSS_DEV
ReactFabric-prod.js 0.0% 0.0% 267.84 KB 267.84 KB 46.23 KB 46.25 KB RN_OSS_PROD
ReactFabric-profiling.js 0.0% 0.0% 277.95 KB 277.95 KB 48.08 KB 48.1 KB RN_OSS_PROFILING
ReactFabric-dev.js 0.0% +0.1% 748.54 KB 748.75 KB 158.78 KB 158.92 KB RN_FB_DEV
ReactNativeRenderer-prod.js 0.0% 🔺+0.1% 276.14 KB 276.14 KB 47.61 KB 47.64 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 285.08 KB 285.08 KB 49.34 KB 49.36 KB RN_OSS_PROFILING
ReactNativeRenderer-dev.js 0.0% +0.1% 743.52 KB 743.71 KB 158.01 KB 158.16 KB RN_FB_DEV

react-interactions

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-interactions-events/press-legacy.development.js +1.1% +1.5% 24.54 KB 24.83 KB 6.15 KB 6.25 KB UMD_DEV
react-interactions-events/hover.production.min.js 0.0% 🔺+0.1% 3.13 KB 3.13 KB 1.14 KB 1.14 KB UMD_PROD
react-interactions-events/press-legacy.production.min.js 0.0% 🔺+0.1% 7.49 KB 7.49 KB 2.85 KB 2.85 KB UMD_PROD
react-interactions-events/drag.development.js 0.0% +0.1% 5.24 KB 5.24 KB 1.55 KB 1.55 KB UMD_DEV
react-interactions-events/keyboard.development.js 0.0% -0.0% 6.1 KB 6.1 KB 2.3 KB 2.29 KB UMD_DEV
react-interactions-events/drag.production.min.js 0.0% 🔺+0.2% 2.26 KB 2.26 KB 1.08 KB 1.08 KB UMD_PROD
react-interactions-events/swipe.production.min.js 0.0% 🔺+0.2% 2.46 KB 2.46 KB 1.11 KB 1.12 KB UMD_PROD
ReactEventsPressLegacy-dev.js +1.2% +1.5% 23.98 KB 24.28 KB 5.92 KB 6 KB FB_WWW_DEV
react-interactions-events/keyboard.development.js 0.0% -0.0% 5.92 KB 5.92 KB 2.25 KB 2.25 KB NODE_DEV
react-interactions-events/swipe.development.js 0.0% +0.1% 5.83 KB 5.83 KB 1.59 KB 1.59 KB NODE_DEV
react-interactions-events/swipe.production.min.js 0.0% 🔺+0.2% 2.28 KB 2.28 KB 1.06 KB 1.06 KB NODE_PROD
react-interactions-events/context-menu.development.js 0.0% +0.1% 2.69 KB 2.69 KB 1013 B 1014 B UMD_DEV
react-interactions-events/input.development.js 0.0% +0.1% 4.54 KB 4.54 KB 1.45 KB 1.45 KB UMD_DEV
react-interactions-events/context-menu.production.min.js 0.0% 🔺+0.3% 1.4 KB 1.4 KB 736 B 738 B UMD_PROD
react-interactions-events/input.production.min.js 0.0% 🔺+0.1% 1.85 KB 1.85 KB 992 B 993 B UMD_PROD
react-interactions-events/scroll.production.min.js 0.0% 🔺+0.1% 2.64 KB 2.64 KB 1.16 KB 1.16 KB UMD_PROD
ReactEventsPress-dev.js +4.0% +4.8% 7.37 KB 7.67 KB 2.17 KB 2.27 KB FB_WWW_DEV
react-interactions-events/context-menu.development.js 0.0% +0.1% 2.5 KB 2.5 KB 969 B 970 B NODE_DEV
react-interactions-events/input.development.js 0.0% +0.1% 4.35 KB 4.35 KB 1.41 KB 1.41 KB NODE_DEV
react-interactions-events/scroll.development.js 0.0% +0.1% 6.13 KB 6.13 KB 1.62 KB 1.62 KB NODE_DEV
react-interactions-events/context-menu.production.min.js 0.0% 🔺+0.1% 1.21 KB 1.21 KB 678 B 679 B NODE_PROD
react-interactions-events/input.production.min.js 0.0% 🔺+0.1% 1.67 KB 1.67 KB 926 B 927 B NODE_PROD
react-interactions-events/scroll.production.min.js 0.0% 🔺+0.1% 2.46 KB 2.46 KB 1.1 KB 1.1 KB NODE_PROD
react-interactions-events/hover.development.js 0.0% +0.1% 6.83 KB 6.83 KB 1.52 KB 1.52 KB NODE_DEV
react-interactions-events/press-legacy.development.js +1.2% +1.5% 24.36 KB 24.64 KB 6.1 KB 6.19 KB NODE_DEV
react-interactions-events/hover.production.min.js 0.0% 🔺+0.1% 2.96 KB 2.96 KB 1.08 KB 1.08 KB NODE_PROD
react-interactions-events/press-legacy.production.min.js 0.0% 🔺+0.1% 7.31 KB 7.31 KB 2.79 KB 2.79 KB NODE_PROD
react-interactions-events/focus.development.js 0.0% 0.0% 15.7 KB 15.7 KB 3.27 KB 3.27 KB UMD_DEV
react-interactions-events/press.development.js +3.2% +3.5% 8.86 KB 9.14 KB 2.65 KB 2.74 KB UMD_DEV
react-interactions-events/tap.development.js 0.0% 0.0% 18.25 KB 18.25 KB 3.93 KB 3.93 KB UMD_DEV
react-interactions-events/focus.production.min.js 0.0% 🔺+0.1% 5.34 KB 5.34 KB 1.77 KB 1.77 KB UMD_PROD
react-interactions-events/press.production.min.js 0.0% 🔺+0.2% 2.66 KB 2.66 KB 1.1 KB 1.11 KB UMD_PROD
react-interactions-events/tap.production.min.js 0.0% 🔺+0.1% 6.35 KB 6.35 KB 2.39 KB 2.39 KB UMD_PROD
react-interactions-events/focus.development.js 0.0% +0.1% 15.51 KB 15.51 KB 3.23 KB 3.23 KB NODE_DEV
react-interactions-events/press.development.js +3.3% +3.6% 8.58 KB 8.86 KB 2.58 KB 2.67 KB NODE_DEV
react-interactions-events/tap.development.js 0.0% 0.0% 18.07 KB 18.07 KB 3.88 KB 3.88 KB NODE_DEV
react-interactions-events/focus.production.min.js 0.0% 🔺+0.1% 5.16 KB 5.16 KB 1.7 KB 1.7 KB NODE_PROD
react-interactions-events/press.production.min.js 0.0% 🔺+0.3% 2.37 KB 2.37 KB 1.02 KB 1.03 KB NODE_PROD
react-interactions-events/tap.production.min.js 0.0% 🔺+0.1% 6.18 KB 6.18 KB 2.35 KB 2.35 KB NODE_PROD

react-noop-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-noop-renderer.development.js +2.9% +2.9% 35.32 KB 36.36 KB 8.04 KB 8.27 KB NODE_DEV
react-noop-renderer-flight-client.development.js 0.0% +0.1% 1.63 KB 1.63 KB 778 B 779 B NODE_DEV
react-noop-renderer.production.min.js 0.0% 0.0% 11.97 KB 11.97 KB 3.83 KB 3.83 KB NODE_PROD
react-noop-renderer-flight-client.production.min.js 0.0% 🔺+0.2% 574 B 574 B 422 B 423 B NODE_PROD
react-noop-renderer-flight-server.production.min.js 0.0% -0.2% 1007 B 1007 B 568 B 567 B NODE_PROD
react-noop-renderer-server.development.js 0.0% -0.1% 1.98 KB 1.98 KB 907 B 906 B NODE_DEV
react-noop-renderer-server.production.min.js 0.0% -0.2% 901 B 901 B 514 B 513 B NODE_PROD
react-noop-renderer-persistent.development.js +2.9% +2.9% 35.43 KB 36.47 KB 8.05 KB 8.29 KB NODE_DEV
react-noop-renderer-persistent.production.min.js 0.0% 0.0% 11.99 KB 11.99 KB 3.84 KB 3.84 KB NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-dev.js +0.1% +0.3% 612.42 KB 613 KB 127.96 KB 128.36 KB FB_WWW_DEV
ReactART-prod.js 0.0% 0.0% 235.58 KB 235.58 KB 40.01 KB 40.01 KB FB_WWW_PROD
react-art.development.js +0.1% +0.2% 670.27 KB 670.77 KB 145.82 KB 146.08 KB UMD_DEV
react-art.production.min.js 0.0% 0.0% 106.19 KB 106.19 KB 32.35 KB 32.35 KB UMD_PROD
react-art.development.js +0.1% +0.2% 600.92 KB 601.42 KB 128.42 KB 128.67 KB NODE_DEV
react-art.production.min.js 0.0% 0.0% 71.16 KB 71.16 KB 21.5 KB 21.5 KB NODE_PROD

react-cache

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactCache-dev.js +22.4% +21.6% 7.66 KB 9.38 KB 2.52 KB 3.06 KB FB_WWW_DEV
ReactCache-prod.js 🔺+6.8% 🔺+5.1% 5.16 KB 5.51 KB 1.62 KB 1.7 KB FB_WWW_PROD
react-cache.development.js +18.4% +14.7% 9.06 KB 10.73 KB 3.05 KB 3.5 KB UMD_DEV
react-cache.production.min.js 🔺+9.5% 🔺+5.4% 2.39 KB 2.62 KB 1.22 KB 1.29 KB UMD_PROD
react-cache.development.js +18.8% +14.9% 8.84 KB 10.5 KB 2.98 KB 3.42 KB NODE_DEV
react-cache.production.min.js 🔺+10.4% 🔺+5.3% 2.2 KB 2.43 KB 1.13 KB 1.19 KB NODE_PROD

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler-persistent.development.js +0.1% +0.2% 599.41 KB 599.88 KB 126.5 KB 126.78 KB NODE_DEV
react-reconciler-reflection.development.js +5.6% +3.9% 18.97 KB 20.02 KB 6.19 KB 6.43 KB NODE_DEV
react-reconciler-persistent.production.min.js 0.0% 0.0% 71.97 KB 71.97 KB 21.31 KB 21.31 KB NODE_PROD
react-reconciler.development.js +0.1% +0.2% 601.93 KB 602.41 KB 127.59 KB 127.89 KB NODE_DEV
react-reconciler.production.min.js 0.0% 0.0% 74.18 KB 74.18 KB 21.87 KB 21.87 KB NODE_PROD

create-subscription

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
create-subscription.development.js +24.7% +20.2% 6.69 KB 8.34 KB 2.43 KB 2.93 KB NODE_DEV
create-subscription.production.min.js 🔺+11.5% 🔺+11.4% 1.99 KB 2.22 KB 1002 B 1.09 KB NODE_PROD

ReactDOM: size: 0.0%, gzip: 🔺+0.1%

React: size: 0.0%, gzip: 🔺+0.1%

Size changes (experimental)

Generated by 🚫 dangerJS against 1569cad

@gaearon
Copy link
Member Author

@gaearon gaearon commented Dec 12, 2019

There's a very minor bundle size for non-React-using entry points increase due to more code paths pulling in the glue code that's only used in DEV. I'll fix that in a follow up that does this at the build time level.

Copy link
Collaborator

@bvaughn bvaughn left a comment

More component stacks is good 👍

@gaearon gaearon mentioned this pull request Dec 12, 2019
@gaearon gaearon merged commit b15bf36 into facebook:master Dec 12, 2019
21 checks passed
NMinhNguyen referenced this issue in enzymejs/react-shallow-renderer Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants